Preserve nominal viewer identities across test and MCP boundaries - #90
Merged
Conversation
There was a problem hiding this comment.
Risk Analysis 🛡️ · Low Risk
✅ Approved — Low-Risk Change
Details
Test-only change to tests/integration/test_cellprofiler_official30_zmq.py (+6/-6). It migrates dict keys and set comparisons from the flattened spec.viewer_type.value string to the authoritative ViewerType enum. Since the produced config.viewer_type is an enum, the prior string-based assertions could never match — this is a correctness fix that keeps the equality checks equally strict. No production code, schemas, migrations, infra, auth, security, or AI prompts are affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ViewerTypeidentitiesMcpViewerConnectionToolFieldsthe declared owner of the viewer connection tool signatureTransportModefrom wire text throughpython-introspectWhy
The configuration ownership refactor correctly preserves nominal transport/viewer types. Two stale boundaries remained:
"fiji"instead ofViewerType.FIJI;ExecutionConnectionSpec, breaking the installed Windows demo.Verification
TransportModechoicestcpandipc