Skip to content

Detailed jupyter error log#2448

Merged
neubig merged 2 commits into
OpenHands:mainfrom
SmartManoj:containers
Jun 16, 2024
Merged

Detailed jupyter error log#2448
neubig merged 2 commits into
OpenHands:mainfrom
SmartManoj:containers

Conversation

@SmartManoj

Copy link
Copy Markdown
Contributor

No description provided.

@xingyaoww xingyaoww left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM


for i in range(10):
output = ''
for i in range(3):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to set this to 3?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously I increased from 5 to 10. Reason for the 5?

kernel_id = 'default'

for i in range(10):
output = ''

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line necessary?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, output won't be defined if connection problem. Better to move into except block

Comment thread opendevin/runtime/plugins/jupyter/execute_cli.py

@neubig neubig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neubig
neubig merged commit cb44c11 into OpenHands:main Jun 16, 2024
malhotra5 pushed a commit that referenced this pull request Mar 25, 2026
Co-authored-by: Engel Nyst <engel.nyst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants