fix: retry errored instances on resume - #771
Open
onatozmenn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #586
Resume currently treats every JSONL row as completed, including rows with a top-level runner error. That makes partial archives skip runtime timeouts and other infrastructure failures.
This keeps raw JSON parsing for old archives, but leaves rows with
errorset eligible for retry. Critic outcomes keep the existing path because they do not set the runner error field.Tested with the resume, aggregation, and async evaluation suites (29 passed), plus Ruff, pycodestyle, and Pyright. The regression test also fails on current
main.