This repository was archived by the owner on May 15, 2026. It is now read-only.
Use charset-normalizer for better coding detection#99
Merged
Conversation
enyst
reviewed
Mar 22, 2025
| """Test detecting UTF-8 encoding with a word and an emoji.""" | ||
| # Create a UTF-8 encoded file with a single word and an emoji | ||
| with open(temp_file, 'w', encoding='utf-8') as f: | ||
| f.write('Hello 😊') |
xingyaoww
approved these changes
Mar 22, 2025
xingyaoww
left a comment
xingyaoww
left a comment
Contributor
There was a problem hiding this comment.
😅 welp - this is unexpected. Thanks for fixing it!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously we used
chardetfor coding detection, and when running on README files with emojis, for some reasons it detected the encoding to beWindows-1252with confidence higher than our threshold (0.73). This PR replaces it with a more modern encoding detection library to avoid that issue.Related Issue
Close #97