Skip to content

fix: update codex-acp version assertion in acp-providers test - #329

Merged
VascoSch92 merged 1 commit into
bump-agent-server-1.41.0from
fix/acp-providers-test-codex-version
Aug 6, 2026
Merged

fix: update codex-acp version assertion in acp-providers test#329
VascoSch92 merged 1 commit into
bump-agent-server-1.41.0from
fix/acp-providers-test-codex-version

Conversation

@VascoSch92

Copy link
Copy Markdown
Member

Summary

Fixes the test (22.12) / test (24.x) CI failures on #327, introduced after #328 merged.

src/__tests__/acp-providers.test.ts hardcoded the expected Codex adapter command as @agentclientprotocol/codex-acp@1.1.2. #328 bumped the actual pinned version in src/models/acp-providers.json to 1.1.7 to match current openhands-sdk ACP_PROVIDERS, so the test's stale assertion started failing.

Test plan

  • npx jest --config jest.config.cjs — 303/303 tests pass locally
  • npx prettier --check src/__tests__/acp-providers.test.ts passes
  • CI green on this branch

The unit test hardcoded @agentclientprotocol/codex-acp@1.1.2, which
went stale after src/models/acp-providers.json was synced to the
current openhands-sdk ACP_PROVIDERS (bumped to 1.1.7 in #328).
@VascoSch92
VascoSch92 merged commit 315f3a4 into bump-agent-server-1.41.0 Aug 6, 2026
1 of 3 checks passed
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Endpoint audit

⚠️ 7 actionable Agent Server contract divergence(s) · report-only

Contract: pinned release artifact

Category Count
Actionable client-only calls 0
Actionable server-only operations 7
Documented non-divergences 12
Agent Server contract operations 117
Audited handwritten client endpoints 118

Actionable client-only calls (0)

none

Actionable server-only operations (7)

  • GET /api/conversations/{}/events
  • GET /api/file/archive
  • GET /api/git/commits
  • GET /api/git/commits/{}/changes
  • GET /api/init
  • POST /api/conversations/{}/load_plugin
  • POST /api/init
Documented non-divergences (12)

Client calls intentionally absent from the filtered contract (10)

  • GET /
  • GET /alive
  • GET /health
  • GET /ready
  • GET /server_info

Reason: Operational Agent Server endpoints intentionally excluded from the filtered public release artifact.
Owner: OpenHands runtime maintainers

  • DELETE /api/meta-profiles/{}
  • GET /api/meta-profiles
  • GET /api/meta-profiles/{}
  • POST /api/meta-profiles/{}
  • POST /api/meta-profiles/{}/activate

Reason: Client-ahead API stacked on the pending Agent Server meta-profiles implementation.
Owner: OpenHands SDK maintainers
Tracking: OpenHands/software-agent-sdk#3744

Server operations covered by an exposed browser URL (2)

  • GET /api/conversations/{}/workspace
  • GET /api/conversations/{}/workspace/{}

Reason: RemoteWorkspace.startWorkspaceSession exposes these authenticated URLs for browser iframe and file requests; they are not HttpClient method calls.
Owner: OpenHands TypeScript client maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant