Distinguish source fields between changesets and presets#258
Conversation
Copied id-tagging-schema’s Sources field into a separate Source field for use in presets, leaving the Sources field largely unmodified. Simplified the code to generate indexed variants of the Source field. Fields that can appear multiple times now use stringsCrossReference to inherit the label from the original base field with the index appended, all independently of the raw key. Added parentheses around the index in the label and localize it according to the current locale’s numeral system.
ba17e2d to
7255655
Compare
|
To verify that this fixes OpenHistoricalMap/issues#1275, I pointed my local copy to an OAuth application I registered on api06.dev.openstreetmap.org, saved a changeset with custom |
|
For convenience when reviewing this pull request, it does not include changes that result from running |
erictheise
left a comment
There was a problem hiding this comment.
Not possible to test without incorporating into ohm-website.
Incorporates OpenHistoricalMap/iD#258 & test fixes
Copied id-tagging-schema’s Sources field into a separate Source field for use in presets, leaving the Sources field largely unmodified. Also simplified the code to generate indexed variants of the Source field. This effectively restores the original combo box Sources field to the changeset editor, where we haven’t implemented multiple source fields and don’t expect as much source metadata as on elements. iD does some magic with the changeset-only Sources field that we don’t want to get in the way of.
Fields that can appear multiple times now use
stringsCrossReferenceto inherit the label from the original base field with the index appended, all independently of the raw key. Added parentheses around the index in the label and localize it according to the current locale’s numeral system.Fixes OpenHistoricalMap/issues#1275.