🏗️🔧:make the health file import survive being run - #1785
Merged
Conversation
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Aug 9, 2026
Running compile.siteifyHealthFiles has been broken for a while. It is only invoked when the health files are missing, so nothing ran it and nobody noticed its output no longer built. Permalinks came out without a trailing slash, so Eleventy wrote an extensionless file instead of `<permalink>/index.html` and failed the build outright. Every committed copy carries the slash, so these had been repaired by hand at some point and the task never learned. The title heading was also stripped with a global regex, harmless only while `##` appeared once per file. OpenINF/.github#885 moves those documents to an `h1` title with `##` sections, at which point the old pattern would have taken all nine of CONTRIBUTING.md's section headings along with the title. It now strips the first heading only, and reads either level so the import works before and after that lands. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
First run since OpenINF/.github#883, #884, and #885 landed, so this picks up the percent-encoded matrix.to aliases, the absolute cross-document links, and the promoted heading levels. Each page is now its upstream file unchanged but for the frontmatter and the title heading the layout renders in its place. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
DerekNonGeneric
force-pushed
the
fix/siteify-health-file-import
branch
from
August 10, 2026 01:13
ae871cb to
9441236
Compare
OpenINFbot
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compile.siteifyHealthFilesimports our five community health files from OpenINF/.github and turns them into site pages.compile.buildPortalonly invokes it when those files are missing, so in practice nothing ran it — and its output had drifted into a state that no longer builds.Wanting to pick up OpenINF/.github#883 (the
matrix.tofix) is what exposed that.The task
Permalinks lost their trailing slash. Eleventy v3 reads
permalink: /about/visionas a request to write an extensionless file and makes it a fatal error, so the build died on the first health file. Every committed copy carries the slash, so these had been repaired by hand at some point and the task never learned.The title heading was stripped with a global regex.
/^## (.*)\n\n/gmwas survivable only while##appeared exactly once per file. OpenINF/.github#885 moves these documents to anh1title with##sections, at which point that pattern eats the document:It now strips the first heading only, and reads either level, so the import behaves the same before and after chore(deps): bump % actions/checkout action@3.5.3 #885.
What it deliberately does not do
Earlier revisions of this PR promoted heading levels and rewrote repo-relative links in the imported prose. Both are gone. The site should not be editing documents it does not own — the divergence is invisible to anyone reading the source, and every future upstream change that upset the validator would have added another rewrite rule here.
Those two problems are fixed at the source instead, in OpenINF/.github#884 and OpenINF/.github#885. What remains here — frontmatter, and lifting the title that the layout re-renders — is packaging, not editing.
Verification
Each imported page is now its upstream file unchanged, but for the frontmatter and that one title heading:
Pages come out with a contiguous outline and no repeated title:
nps buildsucceeds again,verify.allpasses, and the W3C validator is clean across all 27 built pages.Note
The second commit is pure generated output — the first import since #883, #884, and #885 landed.
A follow-up, #1786, corrects
verify.htmlValidForVNU, which has only ever validated the home page — that is how these errors stayed hidden. It is stacked on this branch and needs it to land green.List of any relevant issue numbers: none