Skip to content

🏗️🔧:make the health file import survive being run - #1785

Merged
OpenINFbot merged 2 commits into
livefrom
fix/siteify-health-file-import
Aug 10, 2026
Merged

🏗️🔧:make the health file import survive being run#1785
OpenINFbot merged 2 commits into
livefrom
fix/siteify-health-file-import

Conversation

@DerekNonGeneric

@DerekNonGeneric DerekNonGeneric commented Aug 9, 2026

Copy link
Copy Markdown
Member

compile.siteifyHealthFiles imports our five community health files from OpenINF/.github and turns them into site pages. compile.buildPortal only invokes it when those files are missing, so in practice nothing ran it — and its output had drifted into a state that no longer builds.

Wanting to pick up OpenINF/.github#883 (the matrix.to fix) is what exposed that.

The task

  • Permalinks lost their trailing slash. Eleventy v3 reads permalink: /about/vision as a request to write an extensionless file and makes it a fatal error, so the build died on the first health file. Every committed copy carries the slash, so these had been repaired by hand at some point and the task never learned.

  • The title heading was stripped with a global regex. /^## (.*)\n\n/gm was survivable only while ## appeared exactly once per file. OpenINF/.github#885 moves these documents to an h1 title with ## sections, at which point that pattern eats the document:

    CONTRIBUTING.md headings: 12
      old /gm regex → 3   (lost 9)  ← every section heading destroyed
      new regex     → 11  (lost 1)  ← title only
    

    It now strips the first heading only, and reads either level, so the import behaves the same before and after chore(deps): bump % actions/checkout action@3.5.3 #885.

What it deliberately does not do

Earlier revisions of this PR promoted heading levels and rewrote repo-relative links in the imported prose. Both are gone. The site should not be editing documents it does not own — the divergence is invisible to anyone reading the source, and every future upstream change that upset the validator would have added another rewrite rule here.

Those two problems are fixed at the source instead, in OpenINF/.github#884 and OpenINF/.github#885. What remains here — frontmatter, and lifting the title that the layout re-renders — is packaging, not editing.

Verification

Each imported page is now its upstream file unchanged, but for the frontmatter and that one title heading:

SUPPORT.md             FAITHFUL  headings 2 -> 1 (title only)
SECURITY.md            FAITHFUL  headings 3 -> 2 (title only)
CONTRIBUTING.md        FAITHFUL  headings 12 -> 11 (title only)
CODE_OF_CONDUCT.md     FAITHFUL  headings 1 -> 0 (title only)
VISION.md              FAITHFUL  headings 1 -> 0 (title only)

Pages come out with a contiguous outline and no repeated title:

<h1>Support • Frequently Asked Questions</h1>
<h2>Resources</h2>

nps build succeeds again, verify.all passes, and the W3C validator is clean across all 27 built pages.

Note

The second commit is pure generated output — the first import since #883, #884, and #885 landed.

A follow-up, #1786, corrects verify.htmlValidForVNU, which has only ever validated the home page — that is how these errors stayed hidden. It is stacked on this branch and needs it to land green.

List of any relevant issue numbers: none

@netlify

netlify Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deploy Preview for gh-pages-openinf ready!

Name Link
🔨 Latest commit 9441236
🔍 Latest deploy log https://app.netlify.com/projects/gh-pages-openinf/deploys/6a7925c207035b0008676daa
😎 Deploy Preview https://deploy-preview-1785--gh-pages-openinf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

DerekNonGeneric and others added 2 commits August 10, 2026 00:36
Running compile.siteifyHealthFiles has been broken for a while. It is
only invoked when the health files are missing, so nothing ran it and
nobody noticed its output no longer built.

Permalinks came out without a trailing slash, so Eleventy wrote an
extensionless file instead of `<permalink>/index.html` and failed the
build outright. Every committed copy carries the slash, so these had
been repaired by hand at some point and the task never learned.

The title heading was also stripped with a global regex, harmless only
while `##` appeared once per file. OpenINF/.github#885 moves those
documents to an `h1` title with `##` sections, at which point the old
pattern would have taken all nine of CONTRIBUTING.md's section
headings along with the title. It now strips the first heading only,
and reads either level so the import works before and after that lands.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
First run since OpenINF/.github#883, #884, and #885 landed, so this
picks up the percent-encoded matrix.to aliases, the absolute
cross-document links, and the promoted heading levels.

Each page is now its upstream file unchanged but for the frontmatter
and the title heading the layout renders in its place.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@DerekNonGeneric
DerekNonGeneric force-pushed the fix/siteify-health-file-import branch from ae871cb to 9441236 Compare August 10, 2026 01:13
@DerekNonGeneric DerekNonGeneric changed the title 🏗️🔧:make the health file import produce usable pages again 🏗️🔧:make the health file import survive being run Aug 10, 2026
@OpenINFbot
OpenINFbot merged commit 1c5fd35 into live Aug 10, 2026
13 checks passed
@OpenINFbot
OpenINFbot deleted the fix/siteify-health-file-import branch August 10, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants