Skip to content

fix bug, log warning it key does not exist#23

Merged
mikecarr merged 1 commit intomasterfrom
bugfix/majestic_file_does_not_save_not_exist-22
Nov 29, 2024
Merged

fix bug, log warning it key does not exist#23
mikecarr merged 1 commit intomasterfrom
bugfix/majestic_file_does_not_save_not_exist-22

Conversation

@mikecarr
Copy link
Copy Markdown
Member

@mikecarr mikecarr commented Nov 29, 2024

Description

Log warning if key does not exists instead of throwing and exception

Related Issue

This PR fixes or closes issue: fixes #22

Motivation and Context

How Has This Been Tested

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚙️ Tech (code style improvement, performance improvement or dependencies bump)
  • 📚 Documentation (fix or addition in the documentation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

@mikecarr mikecarr merged commit 0405a7f into master Nov 29, 2024
@mikecarr mikecarr deleted the bugfix/majestic_file_does_not_save_not_exist-22 branch November 29, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Majestic file does not save if parameter does not exist

1 participant