Skip to content

Logging fix#44

Merged
mikecarr merged 6 commits intomasterfrom
logging-fix
Dec 14, 2024
Merged

Logging fix#44
mikecarr merged 6 commits intomasterfrom
logging-fix

Conversation

@mikecarr
Copy link
Copy Markdown
Member

@mikecarr mikecarr commented Dec 14, 2024

Description

Fix #43, clean windows new line chars, be sure to update values. Added Unit tests

Related Issue

This PR fixes or closes issue: fixes #43

Motivation and Context

Fix bugs, camera is unix filesystem, windows line breaks don't work well.

How Has This Been Tested

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚙️ Tech (code style improvement, performance improvement or dependencies bump)
  • 📚 Documentation (fix or addition in the documentation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.

@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
OpenIPC_Config 20% 29% 994
Summary 20% (612 / 3049) 29% (202 / 708) 994

@github-actions
Copy link
Copy Markdown

Test Results

30 tests  ±0   30 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f069ac3. ± Comparison against base commit 89d2468.

@mikecarr mikecarr merged commit 673d673 into master Dec 14, 2024
@mikecarr mikecarr deleted the logging-fix branch June 20, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Majestic Yaml Windows line breaks and not updating

1 participant