Fix restore: compute NAND partition offsets from mtdparts#61
Merged
Conversation
Partition offsets were computed from image data sizes, which are smaller than actual NAND partition sizes (e.g. UBIFS image is 5MB but partition is 8MB). This caused kernel to be written at wrong NAND offset. Now parses mtdparts string to get real partition sizes and computes correct offsets. Handles "-(name)" fill-remainder syntax. Tested: OpenIPC NAND install on hi3516av200 — kernel at 0x200000, rootfs at 0xA00000, all correct. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partition offsets were accumulated from image data sizes, not actual NAND partition sizes. UBIFS images are smaller than their partitions (e.g. 5MB image for 8MB partition), causing kernel/rootfs to be written at wrong offsets.
Now parses
--mtdpartsstring to compute correct partition offsets. Handles-(name)fill-remainder syntax.Tested: OpenIPC NAND install on hi3516av200 — U-Boot cold boots, kernel loads from correct offset (0x200000), UBIFS rootfs mounts, sensor detected.
🤖 Generated with Claude Code