kernel/hi3520dv200: add gpio_i2c include path for nvp6134c#164
Merged
Conversation
nvp6134c/common.h does `#include "gpio_i2c.h"` under HI_GPIO_I2C (set at family level). The header lives in kernel/gpio_i2c/hi3520dv200/, not in kernel/nvp6134c/ itself, so the compile fails with: kernel/nvp6134c/common.h:19:10: fatal error: gpio_i2c.h: No such file Add -I$(src)/gpio_i2c/hi3520dv200 to the kbuild ccflags so nvp6134c finds its dependency. Other extdrv modules (tw286x, cx26828, tlv*) all ship their own gpio_i2c.h copy under their own per-SoC dir, so they find it via the implicit -I$(M-dir) kbuild adds for in-tree modules without needing this.
This was referenced May 18, 2026
hisilicon-opensdk: wire hi3520dv200 (replace 4 vendor blobs with source-built)
OpenIPC/firmware#2109
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the hi3520dv200 source mirror — fix the kbuild include path so `nvp6134c` finds `gpio_i2c.h`.
`nvp6134c/common.h` does `#include "gpio_i2c.h"` under `HI_GPIO_I2C` (set at family level). The header lives in `kernel/gpio_i2c/hi3520dv200/`, not in `kernel/nvp6134c/` itself, so the compile fails with:
```
kernel/nvp6134c/common.h:19:10: fatal error: gpio_i2c.h: No such file or directory
```
Other extdrv modules (tw286x, cx26828, tlv*, etc.) all ship their own `gpio_i2c.h` copy under their own per-SoC dir, so they find it via the implicit `-I$(M-dir)` kbuild adds for in-tree modules — only nvp6134c (top-level, shared across SoCs) needs the explicit family-level include path.
Caught by a local firmware build against this opensdk: every other source-built module compiled clean, nvp6134c's `coax.o` and `nvp6134_drv.o` failed.
Test plan