feat: majestic control center#42
Merged
Merged
Conversation
…ds (Slice A) - Core: MajesticConfigField/Model/FieldEdit + IMajesticConfigSchema contract - Core: pure value-kind-aware diff (ComputeEdits) + section grouping - Devices: MajesticConfigSchema flattens scalars, read-modify-write back - DI: register IMajesticConfigSchema; Core.Tests for the diff
- App: MajesticFieldRowViewModel + MajesticConfigSectionViewModel - SingleCameraPage: collapsible schema-driven 'All settings' editor, grouped by section, type-specific controls (toggle/combo/numeric/text) - video knobs enriched with curated brick-safe option lists; restart hint - ApplyAllSettings diffs rows -> ComputeEdits -> ApplyEdits -> raw POST - en/ru keys; schema injected into VM + factory
- App: IspFields collection (reuses isp-section row VMs), HasIsp/ShowIsp - ApplyIspLive diffs only isp rows, POSTs, refreshes RawJson locally WITHOUT stream restart (Majestic re-reads image params at runtime) - SingleCameraPage: Live ISP toggle (when HasIsp) + collapsible panel - en/ru Isp/IspApply/IspApplied/IspEmpty keys
- Core: PrometheusTextParser + MajesticMetricSample (pure, tested) - IMajesticClient.GetMetricsAsync -> GET /metrics; MajesticHttpClient impl - App: Metrics panel (toggle, on-demand fetch, refresh, name/value list) - en/ru keys; updated SnapshotServiceTests fake Capabilities/endpoints tab deferred — no stable Majestic endpoint to target.
- parser: known-key enum map (codec/profile/size/ircut) -> safe combos, current value merged in so nothing is hidden - editor: live field/section filter (search box) - editor: modified marker + per-field and per-section revert - live ISP rows re-baseline on apply; row VMs reuse Core ValuesEqual - en/ru Search/Revert/RevertSection keys; PlaceholderText (no AVLN5001)
- ValuesEqual(Int) fell through to string compare when long.TryParse rejected a decimal-formatted value, flagging a spurious edit - fall back to numeric (double) comparison; fixes the red CI theory case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related
Type
Checklist
TreatWarningsAsErrors=true).dotnet test); new Core logic has unit tests.AppreferencesCoreonly (Infrastructure / Video / Devices wired via DI in a head).Platforms tested
Screenshots / notes