Merged
Conversation
Member
|
@lvanfretti please fix the failing check. It also appears to have conflicts that should be resolved. @dietmarw do you know what is the issue here? |
Member
The problem is that @lvanfretti reverted the direct commit of the ideal voltage but then based this branch on the previous version (without the revert) which is now part of master. Hence there is a conflict. It does also not help that the branch for this PR is called "IdealVSource" when it should be a current source model. But that can be fixed. |
Added a new ideal voltage source model with user defined real and imaginary part of the voltage phasor along with test models showing its usage.
Cosmetic update.
lvanfretti
force-pushed
the
IdealVSource
branch
2 times, most recently
from
f8eda9d to
8129cd9
Compare
Member
Author
|
@dietmarw thanks for helping me fix the mess I made with the commits! |
Also removed the vendor annotations.
Adding a simple ideal current source component and test model. As several examples of usage for the voltage source have been made, only one test example is made for simplicity.
dietmarw
force-pushed
the
IdealVSource
branch
from
8129cd9 to
6e3449e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a simple ideal current source component and test model. As several examples of usage for the voltage source have been made, only one test example is made for simplicity.