Fix missing Python bindings for OIIO::getattribute#1290
Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom Dec 16, 2015
Merged
Fix missing Python bindings for OIIO::getattribute#1290lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
Conversation
Also notice that the Python bindings for ImageSpec::getattribute were incorrectly bound to "get_attribute". So add "getattribute" and consider "get_attribute" a deprecated synonym.
|
Thanks for the swift patch for this @lgritz! |
Collaborator
Author
|
@iwootten Do you work from master or a release branch? If the latter, which one? |
|
I'm using the 1.5.21 release. It looks like some stuff has gone into RB-1.5 since then, so I guess that means I'm a couple of commits back on RB-1.5. |
Collaborator
Author
|
We are a few days from making 1.6 be the official release. I don't suppose you are in a position to switch to 1.6? Or do I need to backport to 1.5 as well? |
Collaborator
Author
|
Merged into master, RB-1.6, RB-1.5. |
|
Thanks for this! Successfully using it on the 1.5.22 release. |
GerHobbelt
pushed a commit
to GerHobbelt/oiio
that referenced
this pull request
Dec 10, 2024
…oftwareFoundation#1290) Signed-off-by: Bernard Lefebvre <bernard.lefebvre@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is embarrassing: somehow we never added the global getattribute() calls to the Python bindings.
Also notice that the Python bindings for ImageSpec::getattribute were incorrectly bound to "get_attribute". So add "getattribute" and consider "get_attribute" a deprecated synonym.
I will backport this to 1.6, despite being at RC stage, since this is an obvious bug.