IBA::channels (oiiotool --ch) fix: no shuffle makes it forget renaming#1326
Merged
lgritz merged 2 commits intoAcademySoftwareFoundation:masterfrom Jan 25, 2016
Merged
IBA::channels (oiiotool --ch) fix: no shuffle makes it forget renaming#1326lgritz merged 2 commits intoAcademySoftwareFoundation:masterfrom
lgritz merged 2 commits intoAcademySoftwareFoundation:masterfrom
Conversation
The old way was that when CMake runs for the first time (when it builds your make or ninja files), it copies everything from testsuite/ into build/PLATFORM/testsuite/, and then when you run tests, it uses all the info (source images, scripts, and reference output) in the build area. That was fine usually, but if you were developing or modifying a test itself, it was a big PITA, because changing something in testsuite/mytest would not be reflected in the build/PLATFORM/testsuite/mytest that had already been copied. It was the source of many frustrations and errors. And beware modifying something in the build area and then blowing it away, not remembering to copy it to the source testsuite/ area. This overhaul NO LONGER COPIES source data or reference output to build at all. Instead, a combination of links and references to the canonical files are used to make the build area only the temporary location of test output itself. This sure does make everything easier.
lgritz
force-pushed
the
lg-ch
branch
2 times, most recently
from
ab03cbc to
52f0cc0
Compare
When IBA::channels() detected that the channel ordering didn't change, it took an "early out" rather than shuffle data needlessly, but in the process failed to notice any channel renaming that was requested as part of the call.
GerHobbelt
pushed a commit
to GerHobbelt/oiio
that referenced
this pull request
Dec 10, 2024
* Fix: broken doc links Signed-off-by: kanak gautam <kanakgautam5@gmail.com> * replace export -> include Signed-off-by: kanak gautam <kanakgautam5@gmail.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When IBA::channels() detected that the channel ordering didn't change,
it took an "early out" rather than shuffle data needlessly, but in the
process failed to notice any channel renaming that was requested as part
of the call.