ImageInput close/dtr leaving files open fixes#581
Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom Apr 25, 2013
Merged
ImageInput close/dtr leaving files open fixes#581lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
Conversation
* For a couple formats, the ImageInput dtr didn't automatcially close() the file if it was still open. * For a couple formats, a redundant call to close() might have strange effects because it didn't double check that the file was open.
GerHobbelt
pushed a commit
to GerHobbelt/oiio
that referenced
this pull request
Dec 10, 2024
…one) (AcademySoftwareFoundation#581) * Fix some spelling and format issues with comments. Add consistency to how LUT is spelled. "OCIO configuration" or ".ocio configuration file" * Fixing function parameters alignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file if it was still open.
effects because it didn't double check that the file was open.
I'm pretty sure that the docs don't say anything that would guarantee that the ImageInput dtr will close a file if still opened (without an explicit call to close by the app). But almost all of them did call close automatically upon destruction. This just fixes the few that did not.