Skip to content

iconvert: fix to handle multi-image files that can't append subimages#757

Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
lgritz:iconvert
Dec 18, 2013
Merged

iconvert: fix to handle multi-image files that can't append subimages#757
lgritz merged 1 commit intoAcademySoftwareFoundation:masterfrom
lgritz:iconvert

Conversation

@lgritz
Copy link
Copy Markdown
Collaborator

@lgritz lgritz commented Dec 17, 2013

No description provided.

@mszczepanczyk
Copy link
Copy Markdown
Contributor

I could have only checked which writer's open() variety is called and only skimmed through ImageSpec objecs passed to open(), for permutations of the following parameters:

  • multiimage=true and appendsubimage=true/false,
  • muli paged/single paged input image.

As for what I've checked the code looks good.

@lgritz lgritz merged commit a44ff2c into AcademySoftwareFoundation:master Dec 18, 2013
@lgritz lgritz deleted the iconvert branch December 18, 2013 06:15
GerHobbelt pushed a commit to GerHobbelt/oiio that referenced this pull request Dec 10, 2024


* Add azure-pipelines and SonarCloud CI

* Update azure job names

* Remove unnecessary variable quotes

* Change SonarCloud CI link to Azure

* Fix env var curly braces

* Fix boost version variables

* Fix cmake version variables

* Fix sonar-scanner variable typo

* Improve truelight install indentation

* Revert truelight indentation change

* Set scripts to be executable

* Finalize Dockerfiles and scripts

* Fix azure pipelines indentation error

* Fix macOS script path

* Implement gcov code coverage testing into sonar

* Add gcov coverage analysis, refine build

* Updates in response to PR feedback

* Specify c++std, move cxxFlags quotes

* Reconfigure Windows compile flags

* Move Windows cxxFlags to template call

* Revert Windows compile flags

* Remove explicit cxx std from Windows build

* Move Windows cxx flags to CMakeLists.txt

* Add badges to README, additional comments

* Update patch with modern Window preprocessor

* Implement suggested fixes, re-enable disabled builds

* Re-enable /EHsc, correct Windows Azure condition

* Add Windows 2012 install script

* Checkout prior to Windows 2012 dependency install

* Enable ADDLOCAL to msi Python install

* Add Windows env debug step

* Enable quiet install for Python msi

* Move all windows depecency setup to ps1 script

* Add Windows PATH debug script

* Add analyze msi debug log task

* Remove Windows debug task

* Simplify msiexec and set logging path

* Cleanup version parameters

* Split powershell into install specific scripts

* Split macOS installs for clarity

* Organize ci/scripts dir by OS

* Implement ASWF Docker image, Add latest build

* Fix azure expresion typo

* Cleanup whitespace

* Update install scripts with sudo

* Disable warning as error for dependency builds

* Disable OIIO warning as error

* Enable gcov long file names

* Disable OpenEXR tests

* Use correct OpenEXR cmake options

* Use latest tag for "latest" build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants