Describe the bug
A server plugin whose class implements ServerPlugin but none of the eight plugin type interfaces is loaded and instantiated, but never registered. As a result its start() and stop() methods are never called, and it is invisible to the other consumers of the plugin list.
I noticed this while working on #120 (PR #397) and am raising it separately rather than changing the behaviour there, since it may well be intentional.
Details
DefaultExtensionController.initPlugins() instantiates each configured server class and casts it to ServerPlugin, then adds it to the serverPlugins list from inside a series of instanceof branches. The types checked are:
ServicePlugin
ChannelPlugin
CodeTemplateServerPlugin
DataTypeServerPlugin
ResourcePlugin
TransmissionModeProvider
AuthorizationPlugin
MultiFactorAuthenticationPlugin
If a plugin class matches none of these, no branch runs, so nothing adds it to serverPlugins. Because startPlugins() and stopPlugins() iterate that list, such a plugin is never started or stopped.
This also affects two other consumers that iterate getServerPlugins():
AlertWorker collects AlertActionAcceptor implementations from the list. AlertActionAcceptor does not extend ServerPlugin, so it is a marker added onto a plugin class. A plugin implementing ServerPlugin and AlertActionAcceptor, but none of the eight types above, would never receive alert actions.
DefaultUsageController reports plugin usage from the same list, so the plugin would be missing from usage statistics.
Expected behavior
Either:
- A plugin implementing
ServerPlugin is registered and gets start() / stop() called, regardless of which type interfaces it implements; or
- If implementing at least one type interface is a deliberate requirement, the plugin is rejected with a clear log message rather than silently loaded and ignored.
Actual behavior
The plugin is instantiated with no error and then silently ignored: never started, never stopped, and absent from AlertWorker and usage statistics.
Additional context
I have not been able to confirm whether any real plugin is shaped this way, so the practical impact may be nil and this could simply be an undocumented constraint. Flagging it because the silent-ignore path makes it awkward to diagnose from the outside.
Relevant code: DefaultExtensionController.initPlugins(), startPlugins(), stopPlugins(), and AlertWorker's constructor.
Describe the bug
A server plugin whose class implements
ServerPluginbut none of the eight plugin type interfaces is loaded and instantiated, but never registered. As a result itsstart()andstop()methods are never called, and it is invisible to the other consumers of the plugin list.I noticed this while working on #120 (PR #397) and am raising it separately rather than changing the behaviour there, since it may well be intentional.
Details
DefaultExtensionController.initPlugins()instantiates each configured server class and casts it toServerPlugin, then adds it to theserverPluginslist from inside a series ofinstanceofbranches. The types checked are:ServicePluginChannelPluginCodeTemplateServerPluginDataTypeServerPluginResourcePluginTransmissionModeProviderAuthorizationPluginMultiFactorAuthenticationPluginIf a plugin class matches none of these, no branch runs, so nothing adds it to
serverPlugins. BecausestartPlugins()andstopPlugins()iterate that list, such a plugin is never started or stopped.This also affects two other consumers that iterate
getServerPlugins():AlertWorkercollectsAlertActionAcceptorimplementations from the list.AlertActionAcceptordoes not extendServerPlugin, so it is a marker added onto a plugin class. A plugin implementingServerPluginandAlertActionAcceptor, but none of the eight types above, would never receive alert actions.DefaultUsageControllerreports plugin usage from the same list, so the plugin would be missing from usage statistics.Expected behavior
Either:
ServerPluginis registered and getsstart()/stop()called, regardless of which type interfaces it implements; orActual behavior
The plugin is instantiated with no error and then silently ignored: never started, never stopped, and absent from
AlertWorkerand usage statistics.Additional context
I have not been able to confirm whether any real plugin is shaped this way, so the practical impact may be nil and this could simply be an undocumented constraint. Flagging it because the silent-ignore path makes it awkward to diagnose from the outside.
Relevant code:
DefaultExtensionController.initPlugins(),startPlugins(),stopPlugins(), andAlertWorker's constructor.