Skip JAR permissions for unsigned builds #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonygermano
approved these changes
Jul 12, 2025
Member
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
I added some additional context on the related issue. I think this is a smart change.
tonygermano
reviewed
Jul 12, 2025
Member
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
suggestion: expand the commit message
Add some detail to the message body about why this code exists and why we think it's ok to disable it now.
I have also been trying to add trailers to the commit messages like
Issue: https://github.com/OpenIntegrationEngine/engine/issues/138
Github will still recognize that and link the commit to the issue without needing to try to figure out how to wedge it into the commit subject. It's more easily discoverable by analysis tools, as well.
kpalang
approved these changes
Jul 12, 2025
pacmano1
approved these changes
Jul 12, 2025
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net> Issue: OpenIntegrationEngine#138
tonygermano
force-pushed
the
feature/skip-perms-unsigned
branch
from
aacfa79 to
371f041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the build step to add MANIFEST.MF permission attributes if signing is disabled. Closes #138