Skip to content

Fix: Add JavaFX requirement check on startup#278

Open
mgaffigan wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
mgaffigan:feat/detect-missing-jfx
Open

Fix: Add JavaFX requirement check on startup#278
mgaffigan wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
mgaffigan:feat/detect-missing-jfx

Conversation

@mgaffigan
Copy link
Copy Markdown
Contributor

Adds a startup check to verify the environment is acceptable to the app. Can't check for java version since we're targeting bytecode 61, but does check Java FX.

Here's the new startup error.

image

Tested using Azul Zulu JRE 17 FX and SE

Closes #277

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

Test Results

  110 files  ±0    212 suites  ±0   6m 57s ⏱️ + 1m 5s
  650 tests ±0    650 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 300 runs  ±0  1 300 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0cf73f1. ± Comparison against base commit bfe3348.

♻️ This comment has been updated with latest results.

@mgaffigan mgaffigan marked this pull request as ready for review March 28, 2026 23:00
@mgaffigan mgaffigan requested review from a team, NicoPiel, gibson9583, jonbartels, kayyagari, kpalang, pacmano1 and ssrowe and removed request for a team March 28, 2026 23:00
@NicoPiel
Copy link
Copy Markdown
Collaborator

Hmm.. this would prompt some people to go "It says Java 17 required and Java 17 installed.. what am I doing wrong?"

@mgaffigan
Copy link
Copy Markdown
Contributor Author

@NicoPiel

Hmm.. this would prompt some people to go "It says Java 17 required and Java 17 installed.. what am I doing wrong?"

At some point, they do have to understand the difference between SE and FX, but I'm open to other phrasing.

I also assume the message will be used for version issues in the future.

@edthri
Copy link
Copy Markdown

edthri commented Mar 29, 2026

As well as 'Detected Java runtime' could it have a second line addressing the other key factor? e..g. 'JFX..." Displaying JFX version could be confusing so maybe display a status such as 'Present' or 'Not Found'?

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
@mgaffigan mgaffigan force-pushed the feat/detect-missing-jfx branch from df599f8 to 0cf73f1 Compare March 29, 2026 21:32
@mgaffigan
Copy link
Copy Markdown
Contributor Author

@NicoPiel / @edthri, I've updated it to show the missing component. I don't want to go crazy with logic on a failure path.

image

@NicoPiel
Copy link
Copy Markdown
Collaborator

So now it shows both the "JRE X required" and "JFX required" if it's not there?

@mgaffigan
Copy link
Copy Markdown
Contributor Author

@NicoPiel,

Currently, it only has the check for the JavaFX prerequisite:

Open Integration Engine Client requires JavaFX. Please relaunch with a supported JRE.

But it could be extended in the future for the JRE version:

Open integration Engine Client requires JRE 24. Please relaunch with a supported JRE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Cryptic "No suitable pipeline found" crash when running on JRE without JavaFX

3 participants