Feature: Add recent filters drop-down to the message browser#279
Open
mgaffigan wants to merge 3 commits intoOpenIntegrationEngine:mainfrom
Open
Feature: Add recent filters drop-down to the message browser#279mgaffigan wants to merge 3 commits intoOpenIntegrationEngine:mainfrom
mgaffigan wants to merge 3 commits intoOpenIntegrationEngine:mainfrom
Conversation
mgaffigan
changed the title
mgaffigan
force-pushed
the
feature/mru-filters
branch
from
83970d3 to
2cb78d3
Compare
There was a problem hiding this comment.
Pull request overview
Adds a “Recent…” drop-down to the Message Browser so users can quickly re-apply the last ~10 searches per channel, backed by persisted client preferences. To support MRU de-duplication and display text, the shared MessageFilter model gains equality logic and a new criteria-oriented string formatter.
Changes:
- Add client-side storage for per-channel recent message filters (persisted in user preferences) and a “Recent…” UI button to restore them.
- Add
applyFilter(...)plumbing to push a savedMessageFilterback into the advanced filter UI. - Enhance shared filter model objects with
equals/hashCodeand add new test coverage around equality / criteria formatting.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| server/test/com/mirth/connect/model/MessageFilterModelTest.java | Adds unit tests covering MessageFilter equality, emptiness semantics, and criteria-string output. |
| server/src/com/mirth/connect/model/filters/elements/MetaDataSearchElement.java | Implements equals/hashCode for metadata search elements (enables deep equality in filters). |
| server/src/com/mirth/connect/model/filters/elements/ContentSearchElement.java | Implements equals/hashCode for content search elements (enables deep equality in filters). |
| server/src/com/mirth/connect/model/filters/MessageFilter.java | Adds deep equality + isEmpty(), and introduces a criteria-style toString(Map, padding, includeEmptyCriteria) used by the client. |
| client/src/com/mirth/connect/client/ui/browsers/message/MessageBrowserRecentFilterStore.java | New preference-backed store for MRU MessageFilter lists per channel. |
| client/src/com/mirth/connect/client/ui/browsers/message/MessageBrowserAdvancedFilter.java | Adds applyFilter(...) to restore advanced selections from a saved MessageFilter. |
| client/src/com/mirth/connect/client/ui/browsers/message/MessageBrowser.java | Adds “Recent…” button/menu, saves filters on search, and reuses MessageFilter.toString(...) for the criteria pane. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
client/src/com/mirth/connect/client/ui/browsers/message/MessageBrowser.java
Outdated
Show resolved
Hide resolved
client/src/com/mirth/connect/client/ui/browsers/message/MessageBrowser.java
Show resolved
Hide resolved
client/src/com/mirth/connect/client/ui/browsers/message/MessageBrowserRecentFilterStore.java
Show resolved
Hide resolved
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
force-pushed
the
feature/mru-filters
branch
from
2cb78d3 to
b1cefe0
Compare
mgaffigan
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
ssrowe and
tonygermano
and removed request for
a team
Collaborator
|
Great feature. Will look at the code as soon as I am able to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a recent button to the message browser pane. Allows restoration of the last 10 searches on the channel.
Closes #273