Add "Override local binding" to HTTP Sender by jbeckers · Pull Request #333 · OpenIntegrationEngine/engine

jbeckers · 2026-06-30T18:08:01Z

Fixes #332

jbeckers · 2026-06-30T18:09:27Z

No AI was used in the making of this PR, only good ol' manual copy-paste.

jbeckers · 2026-06-30T18:13:34Z

I tested this in a podman container with 2 bridged networks.

Results of "Test connection":

without override

with empty override

with IP 10.88.0.6 override

with IP 10.89.0.3 override

jbeckers · 2026-06-30T18:18:01Z

Sending a message IP 10.89.0.3 override

jbeckers · 2026-06-30T18:19:08Z

This PR probably needs some unit tests. I'll work on that at the end of this week.

Copilot

Pull request overview

Adds an “Override Local Binding” option to the HTTP Sender so outbound HTTP connections (and the “Test Connection” action) can bind to a specific local source IP, aligning HTTP Sender capabilities with other connectors.

Changes:

Added overrideLocalBinding + localAddress properties to HTTP dispatcher settings and wired them through the client UI.
Applied Apache HTTP Client RequestConfig.Builder#setLocalAddress(...) when override is enabled.
Extended connection testing to optionally bind a local address during socket connection tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
server/src/com/mirth/connect/server/util/ConnectorUtil.java	Adds an overload to allow connection tests to bind to a local address.
server/src/com/mirth/connect/connectors/http/HttpDispatcherProperties.java	Introduces new HTTP sender properties for overriding local binding and storing a local address.
server/src/com/mirth/connect/connectors/http/HttpDispatcher.java	Configures Apache HTTP client requests to bind to the configured local address when enabled.
server/src/com/mirth/connect/connectors/http/HttpConnectorServlet.java	Updates “Test Connection” to optionally bind the local address when override is enabled.
client/src/com/mirth/connect/connectors/http/HttpSender.java	Adds UI controls for “Override Local Binding” and “Local Address”, plus validation/reset behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Joachim Beckers <joachim@jbeckers.be>

mgaffigan

Looks like a nice feature! I think some additional work is required to correct the velocity issue, and to fix the DCO check, but after that it looks good to me.

Thanks for sharing!

github-actions · 2026-06-30T21:43:12Z

Test Results

111 files 214 suites 5m 45s ⏱️
651 tests 651 ✅ 0 💤 0 ❌
1 302 runs 1 302 ✅ 0 💤 0 ❌

Results for commit 82c7915.

mgaffigan

@jbeckers - looks all good. Can you fix the DCO? Need that before we can approve.

kpalang

Some changes/clarifications required.

Review comments formatted as conventional comments

kpalang · 2026-07-01T07:37:23Z

 /*
 * Copyright (c) Mirth Corporation. All rights reserved.
- * 
+ *
 * http://www.mirthcorp.com
- * 
+ *
 * The software in this package is published under the terms of the MPL license a copy of which has
 * been included with this distribution in the LICENSE.txt file.
 */


nitpick: While you're here I'd love to see the copyright notice be re-formatted in SPDX format. An example can be found here.

kpalang · 2026-07-01T07:39:42Z

        }

+        if (props.isOverrideLocalBinding()) {
+            if (props.getLocalAddress().length() <= 3) {


question: Why is 3 significant?

kpalang · 2026-07-01T07:41:21Z

+    private void overrideLocalBindingYesRadioActionPerformed(ActionEvent evt) {
+        localAddressField.setEnabled(true);
+        localAddressLabel.setEnabled(true);
+    }
+
+    private void overrideLocalBindingNoRadioActionPerformed(ActionEvent evt) {
+        localAddressField.setEnabled(false);
+        localAddressLabel.setEnabled(false);
+    }


issue: No need to carry the ActionEvent as an argument if it is not used.

kpalang · 2026-07-01T07:42:32Z

 /*
 * Copyright (c) Mirth Corporation. All rights reserved.
- * 
+ *
 * http://www.mirthcorp.com
- * 
+ *
 * The software in this package is published under the terms of the MPL license a copy of which has
 * been included with this distribution in the LICENSE.txt file.
 */


nitpick: While you're here I'd love to see the copyright notice be re-formatted in SPDX format. An example can be found here.

kpalang · 2026-07-01T07:48:59Z

+            final int port;
+            if (url.getPort() != -1) {
+                port = url.getPort();
+            } else if (Strings.CI.equals(url.getProtocol(), "https")) {


thought: Tbh I'm not a fan of a library call for such simple comparison. I might be leaning towards "https".equalsIgnoreCase(url.getProtocol()).

kpalang · 2026-07-01T07:52:14Z

+            final RequestConfig.Builder requestConfigBuilder = RequestConfig.custom()
+                    .setConnectTimeout(socketTimeout)
+                    .setSocketTimeout(socketTimeout)
+                    .setStaleConnectionCheckEnabled(true);


praise: Love the improved readability by splitting each builder function to a new line.

kpalang · 2026-07-01T07:53:17Z

 /*
 * Copyright (c) Mirth Corporation. All rights reserved.
- * 
+ *
 * http://www.mirthcorp.com
- * 
+ *
 * The software in this package is published under the terms of the MPL license a copy of which has
 * been included with this distribution in the LICENSE.txt file.
 */


nitpick: While you're here I'd love to see the copyright notice be re-formatted in SPDX format. An example can be found here.

jbeckers requested review from a team, NicoPiel, gibson9583, jonbartels, kayyagari, kpalang, mgaffigan and ssrowe June 30, 2026 18:08

Add "Override local binding" to HTTP Sender

4221c0a

jbeckers force-pushed the feature/332-add-override-local-binding-to-http-sender branch from fba0393 to 4221c0a Compare June 30, 2026 19:25

mgaffigan requested a review from Copilot June 30, 2026 19:40

Copilot started reviewing on behalf of mgaffigan June 30, 2026 19:41 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread server/src/com/mirth/connect/connectors/http/HttpDispatcher.java

Comment thread server/src/com/mirth/connect/connectors/http/HttpDispatcher.java

Comment thread server/src/com/mirth/connect/connectors/http/HttpConnectorServlet.java

Remove unused import

82c7915

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Joachim Beckers <joachim@jbeckers.be>

mgaffigan requested changes Jun 30, 2026

View reviewed changes

Use the correct velocity replacements

3191e3d

mgaffigan requested changes Jun 30, 2026

View reviewed changes

kpalang requested changes Jul 1, 2026

View reviewed changes

Uh oh!

Conversation

jbeckers commented Jun 30, 2026

Uh oh!

jbeckers commented Jun 30, 2026

Uh oh!

jbeckers commented Jun 30, 2026

Uh oh!

jbeckers commented Jun 30, 2026

Uh oh!

jbeckers commented Jun 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mgaffigan left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 30, 2026

Test Results

Uh oh!

mgaffigan left a comment

Choose a reason for hiding this comment

Uh oh!

kpalang left a comment

Choose a reason for hiding this comment

Uh oh!

kpalang Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

kpalang Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

kpalang Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

kpalang Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

kpalang Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

kpalang Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

kpalang Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants