Add tiered vmoptions to local builds #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony Germano <tony@germano.name>
tonygermano
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
kpalang,
pacmano1 and
ssrowe
and removed request for
a team
engine.vmoptions in the basedir now only has includes for the following three files: /conf/base_includes.vmoptions contains the default options for all runs as of mirth 4.5.2. /conf/default_modules.vmoptions contains the java 9+ options as of 4.5.2. /conf/custom.vmoptions is empty other than usage instructions and is the target for user changes Signed-off-by: Tony Germano <tony@germano.name>
kayyagari
approved these changes
Apr 24, 2025
jonbartels
requested changes
Apr 24, 2025
pacmano1
approved these changes
Apr 24, 2025
Contributor
pacmano1
left a comment
pacmano1
left a comment
There was a problem hiding this comment.
Chatted with @tonygermano on a few items on how the installer handles this. Otherwise no comments.
jonbartels
approved these changes
Apr 24, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2
In the nextgen releases, the vmoptions files were only included with the installation packages, but not in the source tree. This PR adds a tiered vmoptions configuration which gets included at build time.