chore: including missing LICENSE and NOTICE files in sdist#295
Merged
Conversation
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
godobyte
approved these changes
Jun 26, 2026
seant-aws
approved these changes
Jun 26, 2026
leongdl
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The 0.10.1 release had a failure publishing the sdist to PyPI because of a missing LICENSE file https://github.com/OpenJobDescription/openjd-model-for-python/actions/runs/28206698598
What was the solution? (How)
Add the LICENSE file as well as NOTICE and .gitignore files back into the sdist, which matches the contents of the old sdist generated by
hatch buildWhat is the impact of this change?
PublishToPyPI will successfully publish sdist
How was this change tested?
Built the sdist and uploaded to TestPyPI: https://test.pypi.org/project/openjd-model/0.10.2/#files
Compared the sdist generated by the old hatch build system (94129dc) and the one generated by the new build system
Command
Output
Was this change documented?
No
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.