ci: enable Claude PR review with RFC-review guidance#151
Merged
Conversation
Opt in to the two-stage Claude PR-review integration hosted in OpenJobDescription/.github (see OpenJobDescription/.github#23): - claude_pr_review_collect.yml (Stage 1): pull_request-triggered no-op whose completion fires the workflow_run event. Fork PRs see no secrets and nothing this stage produces is trusted. - claude_pr_review.yml (Stage 2): workflow_run-triggered caller that forwards the trusted head repo/SHA and the Bedrock OIDC role secret to the reusable review workflow. Add .claude-review.md, the repo-specific guidance the reviewer reads from the base branch. It directs reviews of rfcs/ changes to follow the methodology in skills/openjd-rfc-review/SKILL.md: alignment with the four design tenets (portable, expressive, human readable/writable, tooling parseable), RFC template completeness, and compatibility with the 2023-09 Template Schemas specification. The skill file remains the source of truth; the guidance inlines the methodology because the reviewer must not read review instructions from the PR head, which is fork-controlled. Signed-off-by: David Leong <116610336+leongdl@users.noreply.github.com>
crowecawcaw
approved these changes
Jul 17, 2026
mwiebe
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables the automated Claude PR review on this repository, targeted at the reusable workflows in
OpenJobDescription/.github(added in OpenJobDescription/.github#23), and adds repo-specific guidance so the reviewer reviews RFCs using the methodology inskills/openjd-rfc-review/SKILL.md.Changes
.claude-review.md(new): repo-specific review guidance the reviewer reads from the base branch. It directs reviews ofrfcs/changes to follow the RFC review skill — alignment with the four design tenets (portable, expressive, human readable/writable, tooling parseable), RFC template completeness perrfcs/0000-template.md, compatibility with the 2023-09 Template Schemas specification, and the common RFC issues to call out (weak motivation, vague specification, missing rationale). It also gives lighter guidance forwiki/,conformance-tests/, andsamples/changes..github/workflows/claude_pr_review_collect.yml(retargeted): the existing Stage-1 stub now callsOpenJobDescription/.githubinstead ofaws-deadline/.github..github/workflows/claude_pr_review.yml(retargeted): the existing Stage-2 stub now callsOpenJobDescription/.github, with a note about the.claude-review.mdguidance.Why the guidance is inlined rather than pointing at the skill file
At review time, files in the PR checkout come from the PR head, which is fork-controlled and treated as untrusted data — the reviewer must not take review instructions from it. The reusable workflow therefore reads
.claude-review.mdfrom the PR's base commit only. This file inlines the skill's methodology (well under the workflow's 16 KiB cap) and namesskills/openjd-rfc-review/SKILL.mdas the source of truth to keep in sync.Testing
zizmor --min-severity highwith the org's centralzizmor.ymlconfig: no findings in the two changed workflows (the 8 pre-existing high findings are unpinned-uses incheck_samples.yml,conformance_tests*.yml, andpublish_wiki.yml, untouched by this PR).Dependencies / ordering
.claude-review.mdsupport) landing first.AWS_CLAUDE_PR_REVIEW_ROLEsecret (OIDC role that can mint a Bedrock bearer token) configured for this repo before reviews will run.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.