Corrected 'New' Char Deletion by cydh · Pull Request #97 · OpenKore/openkore

cydh · 2016-05-11T08:12:52Z

Code review
QA testing on idRO
QA testing on iRO
Fixed deleteDate variable that should store formatted date by [current_time] + [deleteDate]
Added deleteDateTimestamp variable for comparing delete date and current time before selecting/deleting char
Implemented send packets:
- '0829' => ['char_delete2_accept', 'a4 a6', [qw(charID code)]], # 12: Supposed for all clients.
- '098f' => ['char_delete2_accept', 'v a4 a*', [qw(length charID code)]]: idRO.
Implemented received packet:
- '082A' => ['char_delete2_accept_result', 'V V', [qw(charID result)]], # 10: As answer of char_delete2_accept
Fixes Char Deletion #93

Signed-off-by: Cydh Ramdh cydh@pservero.com

* Fixed `deleteDate` variable that should store formatted date by [current_time] + [deleteDate] * Added `deleteDateTimestamp` variable for comparing delete date and current time before selecting/deleting char * Implemented send packets: * `'0829' => ['char_delete2_accept', 'a4 a6', [qw(charID code)]], # 12`: Supposed for all clients. * `'098f' => ['char_delete2_accept', 'v a4 a*', [qw(length charID code)]]`: idRO. * Implemented received packet: * `'082A' => ['char_delete2_accept_result', 'V V', [qw(charID result)]], # 10`: As answer of char_delete2_accept Signed-off-by: Cydh Ramdh <cydh@pservero.com>

cydh · 2016-05-12T04:09:33Z

Well, not quite correct, some clients want as deleteDate as it and other (newer clients) want as deleteDate - curr_date

newer clients => if it's kRO, since 2013+

* Added `charDeleteDateType` in server config since not all clients need same deleteDate value for 'new' delete char. * Set `charDeleteDateType 1` for idRO. Signed-off-by: Cydh Ramdh <cydh@pservero.com>

cydh · 2016-05-14T03:28:38Z

iRO (Renewal) use same method.

* Typo fixes on deletion messages Signed-off-by: Cydh Ramdh <cydh@pservero.com>

cydh · 2016-05-18T00:45:36Z

idk will I'll continue to make PR or not, since my PRs have no respond yet from OK staff.
I have other thing in my local, "Move Char Slot", "Char Renaming", and (todo) "Merge Item (Mergecian NPC feature)"

Signed-off-by: Cydh Ramdh <cydh@pservero.com>

itsrachelfish · 2016-05-20T20:53:15Z

@cydh Unfortunately because most of your changes are idRO specific, I do not want to merge them without having someone to test them. I can do a code review this weekend, but I would still want someone else who plays on idRO to test.

idRO blocks all non-Indonesian IP addresses, so it is impossible for anyone on the OpenKore team to test unless you have an Indonesidan server I could SSH into? :P

If not, do you know anyone who would be willing to test your code and come onto the OpenKore IRC channel this weekend? :)

cydh · 2016-06-13T21:34:20Z

How can u say so man? I even bother to test on iRO, the rest I tested for @rathena.
Then, if the change only for idRO, don't u just test for other server "oh this change doesn't break other server behavior", do u? :P
Maybe same goes like u, said u can test for idRO, same like me that can't for all servers around the world.

for IRC thingy, just asking me on my PR/Issue I made.

itsrachelfish · 2016-06-16T07:48:01Z

@cydh Sorry for the confusion, but I'm not exactly sure what you're trying to say...

All I'm asking for is that someone from idRO (besides you) tests your code before we merge it. Do you think you'd be able to coordinate that?

As a matter of principle, we don't want to merge any code without having another person test it first. Me and @allanon can't test your code because we can't connect to idRO.

If you know anyone else who plays on idRO and uses openkore, please have them test your code and then report back here on GitHub if it worked as expected. Once someone else has tested your code, I'd be happy to merge it!

Does that make sense? 😅

itsrachelfish · 2016-06-16T07:53:47Z


 		my $messageDeleteDate;
 		if ($chars[$num]{deleteDate}) {
-			$messageDeleteDate = TF("\n     -> It will be deleted lefting %s!", $chars[$num]{deleteDate});


What is lefting?

That 'lefting' message, I just copy it from src itself. U can find it.
However, the sentence is weird. It's must be something like "Char can be
deleted on %s"

cydh · 2016-06-16T08:50:16Z

Well, I'll bug some people if u insist (there are many idRO player lately on the issue, but seems they're not interested to test :P)

Ax3l210817 · 2016-06-16T10:03:10Z

@cydh i'am already tested all your coding but how to send it here ? As a proof i'll be tested your coding ?

cydh · 2016-06-16T10:14:43Z

@Ax3l210817 screenshots maybe.

@itsrachelfish u test it on iRO too. I tested it on Renewal server. on iRO timeout after request is 5 sec, but if you relog, the timeout becomes x minutes.

Ax3l210817 · 2016-06-16T10:29:07Z

@cydh okay maybe later night or tommoroww i'll send it here...one by one

Ax3l210817 · 2016-06-16T16:41:24Z

@cydh Delete

Ax3l210817 · 2016-06-16T16:57:59Z

For rename and move sry i can;t gave ss because i don't have any id left to try.....thx may this can help for tester,,,,

itsrachelfish · 2016-06-16T22:38:40Z

@Ax3l210817 Thank you for testing! If you have the time, I'd really appreciate it if you could also test any of the other idRO-specific pull requests that cydh has made. (#89, #96, #117)

@cydh Can you resolve the merge conflicts in this branch? I'll test this on iRO tonight and merge it into master.

Thank you both for your help 😄

cydh · 2016-06-17T01:24:04Z

@Ax3l210817 thank you very much man

@itsrachelfish I'll do it.

Ax3l210817 · 2016-06-17T08:35:54Z

@cydh yw bro

@itsrachelfish okay i'll do when i have time....just to share post ss one by one before and after

Signed-off-by: Cydh Ramdh <cydh@pservero.com>

Ax3l210817 · 2016-06-18T17:22:31Z

@cydh please check your email on pserver i really need u're help about this thx before my email yp****@gmail.com

phinokio · 2016-06-29T05:41:02Z

hello.. plugins autoremake eror after i change the files with this update.. can somebody help for fix it.. idRO

package autoremake;

use strict;
use Plugins;
use Globals;
use Network::Send;
use Misc;
use AI;
use Utils;
use Log qw(message debug);
use Commands;

Plugins::register("autoremake", "Auto delete and Create Character", &onUnload);
my $hooks = Plugins::addHooks(['charSelectScreen', &delete, undef]);

sub onUnload {
Plugins::delHooks($hooks);
}

sub delete {
if ($config{'autodelete'} == 1) {
message("Character Deleted: Yes\n","info");
my (undef, $args) = @_;
Plugins::delHooks($hooks);
$hooks = Plugins::addHooks(['charSelectScreen', &create, undef]);
$messageSender->sendCharDelete($chars[0]{charID}, $config{Email});
$AI::temp::delIndex = 0;
$timeout{'charlogin'}{'time'} = time;
$args->{return} = 2;
} elsif ($config{'autodelete'} != 1) {
message("Character Deleted: NO\n","info");
return 0;
}
}

sub create {
my (undef, $args) = @_;
Plugins::delHooks($hooks);
$hooks = Plugins::addHooks(['charSelectScreen', &login, undef]);
$messageSender->sendCharCreate(0, $config{Nama}, 9, 9, 1, 1, 9, 1, 2, 3);
$timeout{'charlogin'}{'time'} = time;
$args->{return} = 2;
}

sub login {
my (undef, $args) = @_;
Plugins::delHooks($hooks);
$hooks = Plugins::addHooks(['charSelectScreen', &delete, undef]);
$messageSender->sendCharLogin(0);
$timeout{'charlogin'}{'time'} = time;
configModify("autodelete", 0);
$args->{return} = 1;
}

cydh · 2016-06-29T05:54:05Z

@Ax3l210817, just replied. because I need to test it first.

@phinokio, I guess, this is not place for asking a support

JigglyPuffs · 2016-06-29T21:31:52Z

thanks cydh, i've tried it and success..manually deleted char with this changes.
may i ask?where i can learn how to create a plugin?any link for it?

is plugin contens get from misc.pm file?because i got some similarity words there.
thanks

cydh · 2016-06-30T00:48:18Z

Thank you for testing.
About plugin, there is no plenty documentation on OK's wiki, but it's worth
to read. And u can learn for existing plugins in OK's plugins directory.

Now idRO people are searching for working char deletion because last MT. XD
On Jun 30, 2016 04:31, "JigglyPuffs" notifications@github.com wrote:

thanks cydh, i've tried it and success..
may i ask?where i can learn how to create a plugin?any link for it?

is plugin contens get from misc.pm file?because i got some similarity
words there.
thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#97 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AD1K4CYppv3EXsWzr-MntiRePePvClezks5qQuRIgaJpZM4Ib1aI
.

itsrachelfish · 2016-06-30T05:41:33Z

These changes worked for me, however the wording might need to be updated for iRO.

It seems like iRO expects an email address for confirmation, but openkore expects a birthday?

------------------------
Select the character you want to delete.
------------------------------------------
Enter your answer: 1
------------ Confirm delete ------------
#   Choice
0   Back
1   No, don't delete
2   Yes, delete
------------------------
Are you ABSOLUTELY SURE you want to delete:
Slot 2: new char lady (Novice, level 1/1)
     -> It will be deleted lefting Jun 29 23:38:08 2016!
----------------------------------------
Enter your answer: 2
------------ Query ------------
Enter your birthdate or deletion code.
-------------------------------
Enter your answer: [my birthday]
------------ Confirm delete ------------
#   Choice
0   No, don't delete
1   Yes, delete
------------------------
Are you ABSOLUTELY SURE you want to delete:
Slot 2: new char lady (Novice, level 1/1)
     -> It will be deleted lefting Jun 29 23:38:08 2016!
----------------------------------------
Enter your answer: 1
Deleting character new char lady...
Character Deletion has failed because you have entered an incorrect e-mail address.

I tried it again, entering my email address, and it worked. 👍

cydh · 2016-06-30T06:48:04Z

It depends on server policy. kRO is birthdate (fixed 6 chars), iRO is
email, and idRO is called 'personal' key.
On Jun 30, 2016 12:44, "Rachel Fish" notifications@github.com wrote:

Merged #97 #97.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#97 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AD1K4ByYMN3UIN4QknXb_aXtKDpTMTwsks5qQ1ekgaJpZM4Ib1aI
.

JigglyPuffs · 2016-06-30T11:16:46Z

@cydh haha, you know cydh,there a quest that usse deleteing char on IDRO now..but only few people can do it... still confused about use a plugin or macros..

Follow up 38c7fcf

30870b4

* Added `charDeleteDateType` in server config since not all clients need same deleteDate value for 'new' delete char. * Set `charDeleteDateType 1` for idRO. Signed-off-by: Cydh Ramdh <cydh@pservero.com>

* Confirmed as iRO (Renewal) is using 098f to confirm char deletion

f4ceb22

* Typo fixes on deletion messages Signed-off-by: Cydh Ramdh <cydh@pservero.com>

Updated tables/packetdescriptions.txt

66013f9

Signed-off-by: Cydh Ramdh <cydh@pservero.com>

cydh mentioned this pull request Jun 13, 2016

IdRO Character Delete Problem #116

Closed

itsrachelfish reviewed Jun 16, 2016
View reviewed changes

itsrachelfish added needs to be tested needs code review labels Jun 16, 2016

Merge branch 'master' into feature/char_delete2_accept

5506a6d

Signed-off-by: Cydh Ramdh <cydh@pservero.com>

itsrachelfish added server: iRO server: idRO labels Jun 19, 2016

itsrachelfish removed needs code review needs to be tested labels Jun 30, 2016

itsrachelfish merged commit 5397294 into OpenKore:master Jun 30, 2016

cydh mentioned this pull request Dec 3, 2018

Cerroected char_delete2_accept packet #2532

Merged

cydh deleted the feature/char_delete2_accept branch December 5, 2018 14:04

prajwal-raj mentioned this pull request Aug 9, 2026

Fix confusing "lefting" wording in character delete message #4222

Merged

Uh oh!

Conversation

cydh commented May 11, 2016 • edited by itsrachelfish Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cydh commented May 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cydh commented May 14, 2016

Uh oh!

cydh commented May 18, 2016

Uh oh!

itsrachelfish commented May 20, 2016

Uh oh!

cydh commented Jun 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsrachelfish commented Jun 16, 2016

Uh oh!

itsrachelfish Jun 16, 2016

Choose a reason for hiding this comment

Uh oh!

cydh Jun 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cydh commented Jun 16, 2016

Uh oh!

Ax3l210817 commented Jun 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cydh commented Jun 16, 2016

Uh oh!

Ax3l210817 commented Jun 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ax3l210817 commented Jun 16, 2016

Uh oh!

Ax3l210817 commented Jun 16, 2016

Uh oh!

itsrachelfish commented Jun 16, 2016

Uh oh!

cydh commented Jun 17, 2016

Uh oh!

Ax3l210817 commented Jun 17, 2016

Uh oh!

Ax3l210817 commented Jun 18, 2016

Uh oh!

phinokio commented Jun 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cydh commented Jun 29, 2016

Uh oh!

JigglyPuffs commented Jun 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cydh commented Jun 30, 2016

Uh oh!

itsrachelfish commented Jun 30, 2016

Uh oh!

cydh commented Jun 30, 2016

Uh oh!

JigglyPuffs commented Jun 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cydh commented May 11, 2016 •

edited by itsrachelfish

Loading

cydh commented May 12, 2016 •

edited

Loading

cydh commented Jun 13, 2016 •

edited

Loading

cydh Jun 16, 2016 •

edited

Loading

Ax3l210817 commented Jun 16, 2016 •

edited

Loading

Ax3l210817 commented Jun 16, 2016 •

edited

Loading

phinokio commented Jun 29, 2016 •

edited

Loading

JigglyPuffs commented Jun 29, 2016 •

edited

Loading