Skip to content

refactor(domain): migrate PlayerSeasonStats to LoL terminology #52

Description

@NicoRuedaA

Problem or opportunity

PlayerSeasonStats in domain/src/player.rs still uses football terminology for season statistics:

  • goals → should be kills
  • shots → should be creep_score
  • shots_on_target → should be deaths
  • passes_completed → should be �ision_score
  • passes_attempted → should be wards_placed
  • ackles_won → should be damage_dealt
  • interceptions → should be wards_destroyed
  • clean_sheets → should be shutouts
  • minutes_played → should be games_played

Note: player_match_stats table already has LoL columns (v020), but the season aggregate stats struct was never updated.

Proposed solution

Rename fields in PlayerSeasonStats struct to use LoL terminology. Add #[serde(alias = "old_name")] for each renamed field to maintain backwards compatibility with existing saves.

UX impact

  • UI displaying season stats will show correct LoL terminology.
  • Player profile and standings screens affected.

Acceptance criteria

  • All fields in PlayerSeasonStats use LoL terminology
  • Serde aliases exist for every renamed field
  • UI labels updated to match new field names
  • Existing saves load without data loss
  • Tests updated to use new field names

Scope

Data / provenance

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions