Skip to content

feat(media): add more life and diversity in alternative media coverage - #244

Open
Vincent-LAMBERT wants to merge 4 commits into
OpenLeagueManager:developfrom
Vincent-LAMBERT:feat/alternative-media-diversity
Open

feat(media): add more life and diversity in alternative media coverage#244
Vincent-LAMBERT wants to merge 4 commits into
OpenLeagueManager:developfrom
Vincent-LAMBERT:feat/alternative-media-diversity

Conversation

@Vincent-LAMBERT

@Vincent-LAMBERT Vincent-LAMBERT commented May 13, 2026

Copy link
Copy Markdown

Approved issue

Closes #195

  • The linked issue has status:approved.
  • This PR targets development unless it is a maintainer release/hotfix PR.
  • This PR has exactly one type:* label.

Summary

  • Added a streamer comment and a rumour section (5% chances per day) in mods.js to replace and diversify the Al Lio and el_yuste messages
  • Adapted the media story message to take into account broadcasts and podcasts the day after they air.
  • Commented the choices about the build_media_story_from_narrative function previously left unfinished and uncommented
  • Messages received come in priority from the language of the manager or the player language if a comment is centered on him. If none is available, it then comes from english medias
  • Broadcast and podcast medias added for english, spanish and french (no specific media mentioned by contacted people from other languages so default to english)
  • Streamer messages added for every language in OLM
  • Functional translation for every other language in OLM (with DeepL from english and manual check for french)

Checks run

Required/stable PR checks are intentionally lightweight and production-build-free:

  • frontend-install passed (dependency installation validation).
  • rust-check passed (cargo fmt --check and cargo check).
  • Not applicable locally; docs/templates only.

Manual/experimental full checks are available for maintainer-requested validation and current debt tracking:

  • frontend-full-experimental (npm test, npm run build:types).
  • rust-full-experimental (cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace).

Do not mark the experimental full checks as required for this PR unless a maintainer explicitly asks.

Documentation and provenance

  • Documentation was updated or no docs change is needed.
  • Data provenance was updated or no provenance change is needed.
  • No unclear third-party data, generated cache, secret, signing key, or private credential is included.

Release impact

  • Changelog entry added or not needed.
  • Version changes are synchronized across package.json, src-tauri/Cargo.toml, and src-tauri/tauri.conf.json when applicable.

@Vincent-LAMBERT Vincent-LAMBERT changed the title Feat/alternative media diversity feat(media): add more life and diversity in alternative media coverage May 13, 2026
@Vincent-LAMBERT

Copy link
Copy Markdown
Author

Seems like other PR impacted this one with new conflicts. I don't want to erase other people's work so I am supposed to change my code to integrate the new diversity of content that had been added or keep my code untouched and let the maintainer handle the issue ?

@NicoRuedaA

Copy link
Copy Markdown
Contributor

@Vincent-LAMBERT check the merge conflicts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(media): add more life and diversity in alternative media coverage

2 participants