Skip to content

feat: design system, animations, bug fixes, and data cleanup - #283

Merged
aalonsolopez merged 12 commits into
OpenLeagueManager:developfrom
NicoRuedaA:main
Jun 1, 2026
Merged

feat: design system, animations, bug fixes, and data cleanup#283
aalonsolopez merged 12 commits into
OpenLeagueManager:developfrom
NicoRuedaA:main

Conversation

@NicoRuedaA

Copy link
Copy Markdown
Contributor

Summary

Consolidated improvements across design system, asset references, data integrity, and bug fixes.

Changes

File Change
src/App.css Complete @theme tokens (danger, surface, navy scale, shadows), Oswald heading font, keyframe animations, noise/mesh backgrounds, gradient utilities
src/components/ui/Card.tsx shadow-card + hover scale/shadow interaction
src/components/ui/Modal.tsx New generic Modal component with backdrop-blur and scale-in
src/components/ui/Input.tsx New Input with label, error, iconLeft
src/components/ui/Textarea.tsx New Textarea with label and error
src/lib/playerPhotos.ts Removed ERLS imports and lec-player-XXXX legacy pattern
src/components/finances/FinancesTab.tsx Fixed player photos - direct profile_image_url
src/components/dashboard/DashboardHeader.tsx Fixed player search photos
src/components/match/ChampionDraft.tsx Fixed draft player photos
src/components/match/DraftResultScreen.tsx Fixed result screen photos
src/components/dashboard/DashboardSidebar.tsx Removed letter color transition on nav items
src/components/dashboard/DashboardTabContent.tsx Added animate-fade-in-up on tab switch
src/components/dashboard/DashboardModalFrame.tsx Now uses Modal component
src/pages/Dashboard.tsx Added bg-navy-mesh and bg-navy-noise atmosphere
src-tauri/crates/ofm_core/src/transfers.rs Bug fix: filter empty strings from active_lineup_ids after reconcile
src-tauri/crates/db/src/repositories/competition_repo.rs Bug fix: persist League.logo in INSERT/SELECT
src-tauri/src/commands/game.rs Bug fix: apply_default_initial_contract_end treats empty string as missing
data/players/*.json Data fix: contract_end empty strings to null; fixed 7 players with birth years in contract_end
docs/player-fitness-condition.md New documentation for Condition and Fitness systems
src/i18n/locales/en.json, es.json Added common.fitness and match.condition translation keys

Bug Fixes

  1. Competition logos lost on save/load - INSERT/SELECT never included logo column
  2. Players with no contract at game start - empty string treated as Some("") instead of None
  3. False "0 healthy players" after signing - reconcile_lol_active_lineup produced empty strings
  4. Player photos missing in Finances tab - resolvePlayerPhoto called without profile_image_url
  5. Competition card logos - added logo field to LeagueData

Test Plan

  • cargo check passes with no new errors
  • npx tsc --noEmit shows only pre-existing errors
  • npm run build produces valid Vite output
  • npm run tauri build produces .exe + installers

Checklist

  • Conventional commit format used throughout
  • No breaking changes to data format
  • New components documented in src/components/ui/index.ts
  • Player photos unified to single source of truth (profile_image_url)
  • resolvePlayerPhoto legacy code simplified

@NicoRuedaA
NicoRuedaA changed the base branch from main to develop June 1, 2026 19:57
@aalonsolopez
aalonsolopez merged commit 099324a into OpenLeagueManager:develop Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants