Conversation
Merge vNext commits into main
Updates for the release of 24.0.0.12
Set executable permission on shell scripts
Merge vNext and 25.0.0.1 updates to main
leochr
previously approved these changes
Feb 12, 2025
Member
leochr
left a comment
leochr
left a comment
There was a problem hiding this comment.
@gkertasef Thank you for the PR. Looks good. Just one minor comment. But it can be merged and addressed separately.
| .DS_Store | ||
| .project | ||
| #releases/*/*/resources/* | ||
| ##releases/*/*/resources/* |
Member
There was a problem hiding this comment.
This change wouldn't have an effect as the line has already been commented out. I believe Wendy was saying that this line shouldn't be commented out. It'll be good to sort it out.
wraschke
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.