ArtNet RDM does not increment transaction number for each command

[ola-importer]

From si...@nomis52.net on June 09, 2012 22:21:16

Like the title says, the TN isn't incremented and is always set to 0.

Original issue: http://code.google.com/p/open-lighting/issues/detail?id=188

[ola-importer]

From si...@nomis52.net on June 27, 2012 18:55:33

Labels: Component-RDM

[peternewman]

I can confirm this is still present with the latest git.

[peternewman]

I think it may affect all protocols, the code is here:
https://github.com/OpenLightingProject/ola/blob/master/olad/OlaServerServiceImpl.cpp#L665

Specifically:
https://github.com/OpenLightingProject/ola/blob/master/olad/OlaServerServiceImpl.cpp#L688
and
https://github.com/OpenLightingProject/ola/blob/master/olad/OlaServerServiceImpl.cpp#L699

[peternewman]

The Robe widget appears to do it properly, although I can't see anything to wrap round at 255:
https://github.com/OpenLightingProject/ola/blob/master/plugins/usbpro/RobeWidget.cpp#L121

[peternewman]

Also:
https://github.com/OpenLightingProject/ola/blob/master/include/ola/rdm/RDMControllerInterface.h#L78

[peternewman]

I've just changed the 0's in olad/OlaServerServiceImpl.cpp to 42s and this does indeed appear in the RDM packets as expected.