Initial version of Nanoleaf Aurora control#1348
Conversation
| Nanoleaf Plugin | ||
| ============ | ||
|
|
||
| This plugin creates a device per IP, each with one output port. Each port |
There was a problem hiding this comment.
Could you add a link to the product.
There was a problem hiding this comment.
Will do, https://nanoleaf.me/en/consumer-led-lighting/products/smarter-series/nanoleaf-light-panels-smarter-kit/ if you fancy buying some 😄
|
|
||
| uint16_t ip_port; | ||
| if (!StringToInt(m_preferences->GetValue(IPPortKey()), &ip_port)) { | ||
| ip_port = 60221; |
There was a problem hiding this comment.
I'd move this to a const kDefaultPort.
| // Set device options | ||
| m_preferences->SetDefaultValue(PanelsKey(), StringValidator(), ""); | ||
| m_preferences->SetDefaultValue(IPPortKey(), UIntValidator(1, 65535), | ||
| 60221); |
| ola::network::Interface m_interface; | ||
| std::auto_ptr<ola::network::UDPSocketInterface> m_socket; | ||
|
|
||
| NanoleafNode(const NanoleafNode&); |
There was a problem hiding this comment.
Don't we have a macro for these?
There was a problem hiding this comment.
I was briefly confused, having just copied from KiNetNode.h, but yes, this must be DISALLOW_COPY_AND_ASSIGN, I'll fix it up.
There was a problem hiding this comment.
Done, along with other ones that had been missed over the years.
|
This is ready for re-review @nomis52 . I guess it might make sense to merge this in, then I'll work on the other features later. |
|
Merging while failing, due to issues in base code fixed later. |
2 participants
An initial version if you fancy giving it a first pass.
Still todo/future features: