Revert "Replace a few more deprecated pre-C++11 styles"#2044
Merged
peternewman merged 1 commit intomasterfrom Apr 18, 2026
Merged
Revert "Replace a few more deprecated pre-C++11 styles"#2044peternewman merged 1 commit intomasterfrom
peternewman merged 1 commit intomasterfrom
Conversation
This reverts commit 597672a.
DaAwesomeP
approved these changes
Apr 18, 2026
aroffringa
reviewed
Apr 18, 2026
|
|
||
| struct VariableLessThan { | ||
| struct VariableLessThan: public std::binary_function<BaseVariable*, | ||
| BaseVariable*, bool> { |
Contributor
There was a problem hiding this comment.
Technically you don't have to revert this line as the fix was just to remove the (deprecated) base class, which doesn't affect the code otherwise. However, it might be useful to keep the PR as one whole..
Member
Author
There was a problem hiding this comment.
Yeah, and I did find I only needed to undo a subset of the changes across both to fix it, but that feels like more pain than it's worth IMHO, the reverts always seem to end up a nightmare either way...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1890
Please discuss in one place here:
#2035 (comment)