Implement equals and hashcode method into generated classes#4050
Merged
pawel-big-lebowski merged 1 commit intomainfrom Sep 23, 2025
Merged
Conversation
0a350e9 to
4a6754a
Compare
julienledem
approved these changes
Sep 22, 2025
| Run sameRun = ol.newRunBuilder().runId(runId).facets(runFacets).build(); | ||
|
|
||
| assertThat(run.hashCode()).isEqualTo(sameRun.hashCode()); | ||
| assertThat(run).isEqualTo(sameRun); |
Member
There was a problem hiding this comment.
nit: I would also add a negative case. something like:
Run differentRun = ol.newRunBuilder().runId(UUID.randomUUID()).facets(runFacets).build();
assertThat(run.hashCode()).isNotEqualTo(differentRun.hashCode())
assertThat(run).isNotEqualTo(differentRun);
4a6754a to
f0c87ef
Compare
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
f0c87ef to
78223af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
equalsandhashcodemethod into generated classes.Example methods generated:
The change is required for PR 3996 to detect that two daasets have the same facets.