Fix build.sh packaging issues from code review#236
Merged
LeftofZen merged 2 commits intofixmacbuildfrom Mar 15, 2026
Merged
Conversation
Co-authored-by: LeftofZen <7483209+LeftofZen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add initial macOS app bundle packaging step
Fix build.sh packaging issues from code review
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four issues in the
build.shpackaging script identified during review of the macOS app bundle work.Changes
.tar→.tar.bz2to match the actual bzip2 compression (-jflag); updated log message accordinglyCFBundleIconFileand the copy step now referenceloco_icon.png(the asset that exists inGui/Assets/) instead of the non-existentloco_icon.icnsmacos_plist_templatepointed toGui/Packaging/macOS/Info.plistwhich doesn't exist and was never read--no-restoreto all sixdotnet publishcalls —dotnet restoreis already run explicitly before any build function is invoked💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.