Skip to content

[ADD] IDMerger annotate_file_origin default true#5578

Merged
timosachsenberg merged 4 commits into
OpenMS:developfrom
oliveralka:add/IDMerger_annotate_file_origin_true
Oct 10, 2021
Merged

[ADD] IDMerger annotate_file_origin default true#5578
timosachsenberg merged 4 commits into
OpenMS:developfrom
oliveralka:add/IDMerger_annotate_file_origin_true

Conversation

@oliveralka

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change and which issue is fixed.
fixes: #5515

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg timosachsenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let’s check tests

@oliveralka

Copy link
Copy Markdown
Contributor Author

rebuild jenkins

@oliveralka

Copy link
Copy Markdown
Contributor Author

Fail is unrelated:

Starting class and or tool tests...
   Error when uploading file: /Users/builder/jenkins/ws/openms/PR/bldtst/85c1a982/build/Testing/20211009-0540/Test.xml
   Error message was: Operation too slow. Less than 1 bytes/sec transferred the last 120 seconds
   Problems when submitting via HTTP
Backing up and cleaning test results. 

@timosachsenberg
timosachsenberg merged commit 47ca020 into OpenMS:develop Oct 10, 2021
@timosachsenberg
timosachsenberg deleted the add/IDMerger_annotate_file_origin_true branch October 10, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IDMerger make annotate_file_origin=true default

2 participants