Replaced remaining deprecated urlEscape calls. #2008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Catalog
Flyingmana
approved these changes
Feb 10, 2022
elidrissidev
approved these changes
Feb 10, 2022
colinmollenhour
approved these changes
Feb 10, 2022
tmewes
approved these changes
Feb 11, 2022
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The method
urlEscapeinMage_Core_Block_Abstractis deprecated in Magento versions newer than 1.4.0.0-rc1 (for a long time). A few calls to the deprecated method still remained in the codebase, different from the similar and also deprecatedhtmlEscape. This PR replaces the occurrences so that both legacy methods are no longer used in Core.This gives the opportunity to remove both legacy methods altogether in v20.
Contribution checklist (*)