Skip to content

Replaced remaining deprecated urlEscape calls. #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Replaced remaining deprecated urlEscape calls. #2008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/core/Mage/Widget/Model/Widget.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ public function getWidgetDeclaration($type, $params = array(), $asIs = true)
'<img id="%s" src="%s" title="%s">',
$this->_idEncode($directive),
$image,
Mage::helper('core')->urlEscape($directive)
Mage::helper('core')->escapeUrl($directive)
);
return $html;
}
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/base/default/template/catalog/layer/filter.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<?php foreach ($this->getItems() as $_item): ?>
<li>
<?php if ($_item->getCount() > 0): ?>
<a href="<?php echo $this->urlEscape($_item->getUrl()) ?>"><?php echo $_item->getLabel() ?></a>
<a href="<?php echo $this->escapeUrl($_item->getUrl()) ?>"><?php echo $_item->getLabel() ?></a>
<?php else: echo $_item->getLabel() ?>
<?php endif ?>
<?php if ($this->shouldDisplayProductCount()): ?>
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/rwd/default/template/catalog/layer/filter.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<?php foreach ($this->getItems() as $_item): ?>
<li>
<?php if ($_item->getCount() > 0): ?>
<a href="<?php echo $this->urlEscape($_item->getUrl()) ?>">
<a href="<?php echo $this->escapeUrl($_item->getUrl()) ?>">
<?php echo $_item->getLabel() ?>
<?php if ($this->shouldDisplayProductCount()): ?>
<span class="count">(<?php echo $_item->getCount() ?>)</span>
Expand Down
2 changes: 1 addition & 1 deletion ...gn/frontend/rwd/default/template/configurableswatches/catalog/layer/filter/swatches.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ $_swatchOuterHeight = $_dimHelper->getOuterHeight(Mage_ConfigurableSwatches_Help
?>
<li<?php if ($_hasImage){ echo ' style="line-height: ' . $_lineHeight . 'px;"'; } ?>>
<?php if ($_hasItems): ?>
<a href="<?php echo $this->urlEscape($_item->getUrl()) ?>" class="<?php echo $_linkClass ?>">
<a href="<?php echo $this->escapeUrl($_item->getUrl()) ?>" class="<?php echo $_linkClass ?>">
<?php else: ?>
<span class="<?php echo $_linkClass ?>">
<?php endif ?>
Expand Down