Added pypi workflow #136
Conversation
At some point it should be linked to real PyPI server instead of the test one. Also have to uncomment the `on tag` to rebuild and push only when a new release is tagged/made.
Add CENTOS 6 compliant bazel build to workflow
Fixed it as mentioned in google/or-tools#616 (comment)
| wget https://github.com/bazelbuild/bazel/releases/download/2.1.0/bazel-2.1.0-installer-linux-x86_64.sh | ||
|
|
||
| chmod +x bazel-2.1.0-installer-linux-x86_64.sh | ||
| ./bazel-2.1.0-installer-linux-x86_64.sh --user |
There was a problem hiding this comment.
Do you require a specific version of bazel? Bazel 3.0 is installed on Ubuntu 18.06
There was a problem hiding this comment.
We have tested with this bazel version(2.1). Any upgrade in bazel versions needs to be tested
| - name: Renaming wheel | ||
| run: | | ||
| find . -name '*linux*.whl' -type f -exec bash -c 'mv "$1" "${1/linux/manylinux1}"' -- {} \; |
There was a problem hiding this comment.
I don't agree that renaming is the way to go here, you should be using the auditwheel package for compliance, it might break on some systems.
There was a problem hiding this comment.
The package is manylinux1 compliant. So adding it here.
But in the meantime, we are in the process of looking for a permanent solution.
There was a problem hiding this comment.
Hi there ,
@chinmayshah99 let’s open an issue as it is a good practise to normally use auditwheel to publish on PyPi.
It will enable to keep track or the changes.
There was a problem hiding this comment.
Yeah, let's do this. Are you creating an issue?
not needed.
|
Squashing this as it's 48 commits |
5 participants
Description
Finished pypi auto-release via github actions
Fixes #113
Partial issue #111 , #119
Type of change
Please mark options that are relevant.