Added support for macOS#147
Conversation
- Removed third_party folder - Updated Bazel WORKSPACE - Fixed paths in example/carrots.py - Added Pipfile for virtualenv - Added build_macos.sh script
iamtrask
left a comment
There was a problem hiding this comment.
Looks great to me! But I’d wait until another review before merging.
- Fixed pydp.so cleanup before new build
|
Hrm... looks like i have broken things. I actually was trying to get this Commit in. I made the mistake of thinking maybe I should try the GitHub Desktop app and I think that just made it worse with some weird merge strategy auto stuff... I should have manually force pushed this branch up onto my fork first. Now I am hesitant to do anything in case I make it worse. If someone wants to make the change above I linked to, I believe it fixes an error in the xargs command on linux CI. But this needs to be confirmed, although its not really needed on CI since its a clean environment which would explain why this didn't get noticed. We could possibly put something like: set -o pipefailThat way any error will cause the test to fail so we don't miss silent errors. |
|
Other than that update, I think the PR is good! 👍 |
|
Also how do we feel about Squash and Force Push on branches like these before Merging the PR? |
* added publishing for pypi * bazel is already installed lol * twine needs to be run via pipenv * Mac workflow test (#6) * Update pypipublish_osx.yml * cleaning up files after testing
Manually adding this. |
|
@madhavajay |
If the code does one functionality then yes. |
|
Regarding the xargs error, its always a challenge to get bash scripts to work perfectly on linux and mac, but I should have actually tested it on a local docker container first. Sorry for that, this works and has been tested on both platforms: find ./ -name pydp.so -print0 | xargs -0 -I {} rm {}For the commits I just mean there are a lot of "fixing errors" commits in this PR which could be squashed into a single commit. Its just a style preference and doesn't really matter but makes reviewing the whole PR in the longer history of the repo a little easier. |
|
This looks great. Can you make a PR if you don't mind? |
Fixes #143
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Yes the carrots demo runs.