Skip to content

[WIP] Added a more compact name and type lookup.#225

Merged
chinmayshah99 merged 1 commit intoOpenMined:test-capifrom
BenjaminDev:count-refactor
Aug 7, 2020
Merged

[WIP] Added a more compact name and type lookup.#225
chinmayshah99 merged 1 commit intoOpenMined:test-capifrom
BenjaminDev:count-refactor

Conversation

@BenjaminDev
Copy link
Copy Markdown
Member

@BenjaminDev BenjaminDev commented Aug 7, 2020

Description

Following the same pattern proposed by @alejandrosame here is a possible compact version for looking up name and type. Note it breaks with the bounded functions as it stamps out BoundedMeanInt and BoundedMeanDouble etc. But can be fixed if we adopt this approach.

@chinmayshah99 suggested that we make a numpy style api like #204
"What would be great is mention the datatype of the list in another argument,"

x.result([1,2,3,4], 'int') 

How do we want to address this as I think it's best done/explored early.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • All test_count.py tests pass.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@chinmayshah99 chinmayshah99 merged commit a926b60 into OpenMined:test-capi Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants