[WIP] Added a more compact name and type lookup.#225
Merged
chinmayshah99 merged 1 commit intoOpenMined:test-capifrom Aug 7, 2020
Merged
[WIP] Added a more compact name and type lookup.#225chinmayshah99 merged 1 commit intoOpenMined:test-capifrom
chinmayshah99 merged 1 commit intoOpenMined:test-capifrom
Conversation
…combinations as sum maybe not supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the same pattern proposed by @alejandrosame here is a possible compact version for looking up name and type. Note it breaks with the bounded functions as it stamps out
BoundedMeanIntandBoundedMeanDoubleetc. But can be fixed if we adopt this approach.@chinmayshah99 suggested that we make a numpy style api like #204
"What would be great is mention the datatype of the list in another argument,"
How do we want to address this as I think it's best done/explored early.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
test_count.pytests pass.Checklist