Skip to content

[WIP] Added a more compact name and type lookup. #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chinmayshah99 merged 1 commit into from
Aug 7, 2020
Merged

[WIP] Added a more compact name and type lookup. #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 9 additions & 26 deletions src/bindings/PyDP/pydp_lib/algorithm_builder.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,34 +49,17 @@ class AlgorithmBuilder {
.ValueOrDie();
}

std::map<std::type_index, std::string> type_to_name = {{typeid(double), "Double"},
{typeid(int), "Int"}};
std::map<std::type_index, std::string> algorithm_to_name = {
{typeid(dp::BoundedMean<T>), "BoundedMean"},
{typeid(dp::BoundedSum<T>), "BoundedSum"},
{typeid(dp::BoundedStandardDeviation<T>), "BoundedStandardDeviation"},
{typeid(dp::BoundedVariance<T>), "BoundedVariance"}};

std::string get_algorithm_name() {
// Set the suffix string
std::string suffix = "";
// TODO: Change to mapping function
if (typeid(T) == typeid(int)) {
suffix = "Int";
} else if (typeid(T) == typeid(double)) {
suffix = "Double";
} else {
throw std::runtime_error("Binding error - Only int and double types supported");
}

// Set the algorithm name string
std::string name = "";
// TODO: Change to mapping function
if (typeid(Algorithm) == typeid(dp::BoundedMean<T>)) {
name = "BoundedMean";
} else if (typeid(Algorithm) == typeid(dp::BoundedSum<T>)) {
name = "BoundedSum";
} else if (typeid(Algorithm) == typeid(dp::BoundedStandardDeviation<T>)) {
name = "BoundedStandardDeviation";
} else if (typeid(Algorithm) == typeid(dp::BoundedVariance<T>)) {
name = "BoundedVariance";
} else {
throw std::runtime_error(std::string("Binding error - Unsupported algorithm: ") +
std::string(typeid(Algorithm).name()));
}
return (name + suffix);
return (algorithm_to_name[typeid(Algorithm)] + type_to_name[typeid(T)]);
}
};

Expand Down