Introduce Python and C++ code coverage reports and checks#262
Merged
chinmayshah99 merged 3 commits intoOpenMined:devfrom Aug 22, 2020
Merged
Introduce Python and C++ code coverage reports and checks#262chinmayshah99 merged 3 commits intoOpenMined:devfrom
chinmayshah99 merged 3 commits intoOpenMined:devfrom
Conversation
chinmayshah99
requested changes
Aug 21, 2020
chinmayshah99
approved these changes
Aug 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements #256 and #257. The current minimum coverage requirement for the CI check is 80%, which is specified by the
MIN_COVERAGEvariable inside.envfile. The Makefile has the following new actions:check-coverage-python: ensures that Python code coverage is at leastMIN_COVERAGE%. Automatically called bymake test.check-coverage-cpp: ensures that C++ code coverage is at leastMIN_COVERAGE%. Automatically called bymake test.show-coverage: collects coverage data generated during test execution and opens its report on a browser tab [see image below].Affected Dependencies
Added the following python dependencies:
coverageto generate Python coverage reports.gcovrto generate C++ coverage reports.How has this been tested?
make testexecuted succesfullyChecklist