SimulationRuntime: Fix segfault when FMU model calls terminate#16024
Open
jschueller wants to merge 1 commit into
Open
SimulationRuntime: Fix segfault when FMU model calls terminate#16024jschueller wants to merge 1 commit into
jschueller wants to merge 1 commit into
Conversation
When a Modelica model calls terminate() inside an FMU, the generated code longjmps via MMC_THROW(). The FMU runtime catch blocks in internalEventUpdate and internal_CompletedIntegratorStep treated this identically to assertion failures, returning fmi2Error without setting the terminateSimulation flag. Importers like PyFMI then crashed with a segfault upon receiving fmi2Error. Fix by: - Adding _terminate_simulation_requested flag to ModelInstance structs - Providing an FMU-specific omc_terminate that sets this flag before throwing, letting catch blocks distinguish terminate from assertions - Setting eventInfo.terminateSimulation = fmiTrue and returning OK instead of error when terminate is detected - Checking terminateSimulation in fmi2DoStep/fmu3DoStepInternal to exit the integration loop cleanly Closes OpenModelica#9474
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Modelica model calls terminate() inside an FMU, the generated code longjmps via MMC_THROW(). The FMU runtime catch blocks in internalEventUpdate and internal_CompletedIntegratorStep treated this identically to assertion failures, returning fmi2Error without setting the terminateSimulation flag. Importers like PyFMI then crashed with a segfault upon receiving fmi2Error.
Fix by:
Closes #9474