Fix MaterialX shader generation when building the complete OpenMoonRay source tree. - #275
Open
nicolaspopravka wants to merge 1 commit into
Open
Conversation
Signed-off-by: Nicolas Popravka <nicolaspopravka@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility:
patch
Issues/Tickets:
Release notes comment:
Fix MaterialX shader generation when building the complete OpenMoonRay source tree.
Comments for the reviewer:
materialx_shaderschecks for thescene_rdl2directory in the OpenMoonRay build tree during CMake configuration.openmoonraycurrently addsmaterialx_shadersfirst, so that directory does not exist yet and the shader generator does not receive thescene_rdl2Python path.Configure
scene_rdl2beforematerialx_shadersso the existing path and CMake logic is used.This is exposed by a clean build with
BUILD_MATERIALX_SHADERS=ONand no previously installedscene_rdl2Python module. Builds where the option is disabled orscene_rdl2is already available throughPYTHONPATHdo not encounter it.I tested this with OpenMoonRay v2026.29.1 and
BUILD_MATERIALX_SHADERS=ON. The full build completed, generated and installedmaterialx_shaders/shaders.py, and installed the shader JSON files. MoonRay,hd_render, andusdrecordrender checks passedLook or scene setup change:
Special notes for production:
Attention/Reviewers:
AI Assisted Development:
Assisted-by: OpenAI Codex / GPT-5
I used Codex to investigate and implement the initial change and prepare the validation. I reviewed the patch and test results and take responsibility for the contribution.
Checklist: