Recognize G502 X LIGHTSPEED direct-USB PID (0xc098) - #43
Merged
Conversation
lsusb showed the mouse enumerating directly as 046d:c098 ("G502 X
LIGHTSPEED") when connected by USB cable, distinct from its Lightspeed
dongle connection. That PID was missing from the direct-connect
product list, so a cable-connected G502 X LIGHTSPEED wouldn't be
recognized as a direct HID++ endpoint.
Cross-checked against Solaar's descriptors.py: it has no static PID
entry for the G502 X family either (G502 X, X PLUS, X LIGHTSPEED all
rely on runtime HID++ 2.0 feature-table probing rather than a
hardcoded quirks entry), which matches this driver's approach — no
further special-casing needed for core features (DPI, buttons,
battery, onboard profiles). Solaar's only model-specific carve-out is
an RGB NVConfig color allowlist scoped to G502 X PLUS's modelId
specifically; this codebase has no equivalent allowlist to update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lsusbshowed a G502 X LIGHTSPEED enumerating directly as046d:c098when connected by USB cable, distinct from its Lightspeed dongle connection.LOGITECH_DIRECT_PRODUCT_IDS, so a cable-connected G502 X LIGHTSPEED wouldn't be recognized as a direct HID++ endpoint.0xc098to the direct-connect PID list and its doc comment, plus test coverage inhidpp.test.ts.Cross-check against Solaar
Checked Solaar's
descriptors.py: it has no static PID entry for the G502 X family either (G502 X, X PLUS, X LIGHTSPEED all rely on runtime HID++ 2.0 feature-table probing rather than a hardcoded quirks entry), which matches this driver's approach — no further special-casing needed for core features (DPI, buttons, battery, onboard profiles). Solaar's only model-specific carve-out is an RGB NVConfig color allowlist scoped to G502 X PLUS's modelId specifically; this codebase has no equivalent allowlist to update.Testing
npm test— 818/818 passing🤖 Generated with Claude Code
https://claude.ai/code/session_016PAJakuepDJB8rZVc5ZFyy
Generated by Claude Code