fix(supported): fold live-catalog brand typos onto canonical names - #109
Merged
jazzstack merged 1 commit intoAug 16, 2026
Merged
Conversation
The support catalog stores manufacturer as free text, so spellings like 'redragon' (lowercase), 'RedDragon', 'Logitec', 'Glorius' and 'rapoo Vpro' rendered as their own brand groups on the page. canonicalBrand() now maps every normalized variant of a known static-table brand onto its canonical display name, with an explicit alias map for genuine spelling typos. The whole Redragon family (20 catalog rows) now renders under 'Redragon'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What The supported-devices page was still showing multiple similar Redragon groups, some misspelled. Root cause: the support catalog stores manufacturer as free text, and canonicalBrand() only folded the exact reddragon typo. Querying the live catalog (377 rows) showed: - redragon (lowercase) x5 and RedDragon x2 alongside Redragon x13 - other typos: Logitec, Glorius, rapoo Vpro ## Fix canonicalBrand() now: - derives canonical display names from the static table keyed by normalized form, so any casing/spacing variant of a known brand (e.g. redragon, LogiTech, steelseries, g-wolves) renders with the canonical name - keeps an explicit alias map for genuine spelling typos (reddragon, logitec, glorius, rapoovpro) ## Verification - Verified against the live catalog: all 20 Redragon-family rows render under Redragon; distinct brands drop 161 -> 127 - npm test: 81 pass - npm run build: clean