Skip to content

[in1Data/com1DFA] Modification of basic functions - #1331

Merged
fso42 merged 1 commit into
masterfrom
JL_AdaptGetAndCheckInputFiles
Aug 24, 2026
Merged

[in1Data/com1DFA] Modification of basic functions#1331
fso42 merged 1 commit into
masterfrom
JL_AdaptGetAndCheckInputFiles

Conversation

@JuLa96

@JuLa96 JuLa96 commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Modification of some basic functions that they can be used for the development of DebrisFrame modules.

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

@JuLa96 JuLa96 added enhancement New feature or request DebrisFrame labels Aug 19, 2026
@JuLa96
JuLa96 requested a review from PaulaSp3 August 19, 2026 15:25
@PaulaSp3
PaulaSp3 requested a review from fso42 August 19, 2026 17:49
@PaulaSp3

PaulaSp3 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Instead of mofifying the functions, you could also execute them with norm(x, y, 0).
Did you check, why the pytest fails?

@JuLa96
JuLa96 force-pushed the JL_AdaptGetAndCheckInputFiles branch from 421bd9b to cb15a65 Compare August 20, 2026 06:27
@qltysh

qltysh Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

All good ✅

@qltysh

qltysh Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA100.0%

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
avaframe/com1DFA/DFAtools.py100.0%
Coverage rating: A Coverage rating: A
avaframe/in1Data/getInput.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

fso42
fso42 requested changes Aug 20, 2026
View reviewed changes
Comment thread avaframe/com1DFA/DFAtools.py
Comment thread avaframe/in1Data/getInput.py
@JuLa96
JuLa96 requested a review from fso42 August 20, 2026 13:22
@JuLa96
JuLa96 force-pushed the JL_AdaptGetAndCheckInputFiles branch from 8f060a0 to 8108f56 Compare August 21, 2026 11:07
@JuLa96 @fso42
adapt getInput.getAndCheckInputFiles() in order to
969b9e6 
support csv-files

generalize DFAtools.normalize() in order to handle
2D-vectors

modify test_com1DFA.py due to modified function
DFAtls.normalize()
@fso42 fso42 assigned fso42 and unassigned JuLa96 Aug 24, 2026
@fso42
fso42 force-pushed the JL_AdaptGetAndCheckInputFiles branch from 8108f56 to 969b9e6 Compare August 24, 2026 08:16
@fso42

fso42 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Standardtests ident

@fso42
fso42 merged commit f7df023 into master Aug 24, 2026
5 checks passed
@fso42
fso42 deleted the JL_AdaptGetAndCheckInputFiles branch August 24, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fso42 fso42 fso42 approved these changes
@PaulaSp3 PaulaSp3 PaulaSp3 approved these changes

Assignees

@fso42 fso42

Labels

DebrisFrame enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JuLa96 @PaulaSp3 @fso42