Skip to content

[com1]: time dependent release file with x and y cooridnates and velocity components - #1334

Merged
fso42 merged 1 commit into
masterfrom
PS_coordsTimeDepRel
Aug 26, 2026
Merged

[com1]: time dependent release file with x and y cooridnates and velocity components#1334
fso42 merged 1 commit into
masterfrom
PS_coordsTimeDepRel

Conversation

@PaulaSp3

@PaulaSp3 PaulaSp3 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

2 options for a time dependent release:

  • in REL folder: shp file with polygon + csv file (containing timestep, thickness, velocity)
    (here velocity is the magnitude, the direction is computed to the steepest descent, as it was before)
  • in REL folder: csv file containg: x,y coordinated, time step, thickness, velocityX, velocityY, velocityZ
    (direction of initial movement is defined)

The question is, if we also only allow providing velocity components for option 1. (See Issue OpenNHM/DebrisFrame#87).
The report is not adapted yet (Issue OpenNHM/DebrisFrame#89).

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

@PaulaSp3
PaulaSp3 requested review from awirb and fso42 August 20, 2026 12:40
@PaulaSp3 PaulaSp3 self-assigned this Aug 20, 2026
@PaulaSp3 PaulaSp3 added enhancement New feature or request DebrisFrame labels Aug 20, 2026
@qltysh

qltysh Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Analysis for project AvaFrame

❌ 4 blocking issues (5 total)

Tool Category Rule Count
black Style Incorrect formatting, autoformat by running qlty fmt. 4
qlty Structure Function with high complexity (count = 15): plotReleaseScenarioView 1

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/debrisFunctions.py Outdated
Comment thread avaframe/in1Data/getInput.py
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/debrisFunctions.py
Comment thread avaframe/in1Data/getInput.py Outdated
Comment thread avaframe/in1Data/getInput.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/debrisFunctions.py Outdated
Comment thread avaframe/in1Data/getInput.py
Comment thread avaframe/in1Data/getInput.py
Comment thread avaframe/in1Data/getInput.py Outdated
Comment thread avaframe/in1Data/getInput.py Outdated
@qltysh

qltysh Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA73.6%

Modified Files with Diff Coverage (3)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
avaframe/in1Data/getInput.py79.3%237, 1223-1225...
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py55.0%625-627, 630-632...
Coverage rating: F Coverage rating: C
avaframe/com1DFA/debrisFunctions.py96.9%59
Total76.6%
🤖 Increase coverage with AI coding...
In the `PS_coordsTimeDepRel` branch, add test coverage for this new code:

- `avaframe/com1DFA/com1DFA.py` -- Lines 625-627, 630-632, 671-673, 3469-3471, and 3888-3894
- `avaframe/com1DFA/debrisFunctions.py` -- Line 59
- `avaframe/in1Data/getInput.py` -- Lines 237, 1223-1225, 1227-1229, 1238-1240, 1322-1324, and 1350-1353

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Comment thread avaframe/com1DFA/debrisFunctions.py
@PaulaSp3
PaulaSp3 force-pushed the PS_coordsTimeDepRel branch 2 times, most recently from 786de87 to 0cc77db Compare August 24, 2026 17:05
@PaulaSp3
PaulaSp3 force-pushed the PS_coordsTimeDepRel branch 2 times, most recently from da7f5e0 to 6bb3f5a Compare August 26, 2026 08:38
@fso42
fso42 removed the request for review from awirb August 26, 2026 11:33
@fso42 fso42 assigned fso42 and unassigned PaulaSp3 Aug 26, 2026
…y components

add tests and checks for csv input
@fso42
fso42 force-pushed the PS_coordsTimeDepRel branch from 6bb3f5a to 7fd61d5 Compare August 26, 2026 11:38
@fso42
fso42 merged commit c745a2d into master Aug 26, 2026
5 of 6 checks passed
@fso42
fso42 deleted the PS_coordsTimeDepRel branch August 26, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DebrisFrame enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants