[com1]: time dependent release file with x and y cooridnates and velocity components - #1334
Merged
Conversation
Contributor
Analysis for project
|
| Tool | Category | Rule | Count | |
|---|---|---|---|---|
| black | Style | Incorrect formatting, autoformat by running qlty fmt. |
4 | ❌ |
| qlty | Structure | Function with high complexity (count = 15): plotReleaseScenarioView | 1 |
@qltysh one-click actions:
- Auto-fix formatting (
qlty fmt && git push)
fso42
requested changes
Aug 20, 2026
Contributor
|
Coverage Impact This PR will not change total coverage. Modified Components (1)
Modified Files with Diff Coverage (3)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
PaulaSp3
force-pushed
the
PS_coordsTimeDepRel
branch
2 times, most recently
from
August 24, 2026 17:05
786de87 to
0cc77db
Compare
fso42
approved these changes
Aug 25, 2026
PaulaSp3
force-pushed
the
PS_coordsTimeDepRel
branch
2 times, most recently
from
August 26, 2026 08:38
da7f5e0 to
6bb3f5a
Compare
…y components add tests and checks for csv input
fso42
force-pushed
the
PS_coordsTimeDepRel
branch
from
August 26, 2026 11:38
6bb3f5a to
7fd61d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

2 options for a time dependent release:
(here velocity is the magnitude, the direction is computed to the steepest descent, as it was before)
(direction of initial movement is defined)
The question is, if we also only allow providing velocity components for option 1. (See Issue OpenNHM/DebrisFrame#87).
The report is not adapted yet (Issue OpenNHM/DebrisFrame#89).
PR Checklist
Please confirm before requesting review:
pytestlocally without failsConfirm before the final merge/rebase into master