NMS-19128: Trap Config to DB (new UI)#8446
Merged
Conversation
Contributor
christianpape
commented
Apr 14, 2026
christianpape
commented
- JIRA: https://opennms.atlassian.net/browse/NMS-19128
* initial changes * general configuration ui * changes * Changes
…/trap-config-to-db
…/trap-config-to-db
…/trapd-config-db-migration
* create user * fixes * fixes * revert changes * changes * new changes * changes
…/trap-config-to-db
…/trapd-config-db-migration
…/trapd-config-db-migration
…#8363) * upload, get and update rest endpoints * changes for dto * test cases * new rest endpoints or snmp v3 users * mappers fixes * field use address from varbind fix * changes * new fixes * new changes * test cases fix * test fix * checkes reverted * user updates changes * unused code removed * menu item * review changes * response messages update * DAO update fix
…/trapd-config-db-migration
…#8370) * upload, get and update rest endpoints * changes for dto * test cases * new rest endpoints or snmp v3 users * mappers fixes * field use address from varbind fix * Trapd UI rest endpoint integration * new changes * new changes * changes * changes * changes * change * search changes * changes * new fixes * new changes * test cases fix * test fix * api changes * checkes reverted * new changes for fe * changes * test coverage * user updates changes * scv changes and test coverage * unused code removed * menu item * route fix * test fixes * naming fixes * unused imports * review changes * response messages update * validator fix * DAO update fix * DAO fixes * changelog * New changes and test fixes * new fixes * test fix
* upload, get and update rest endpoints * changes for dto * test cases * new rest endpoints or snmp v3 users * mappers fixes * field use address from varbind fix * Trapd UI rest endpoint integration * new changes * new changes * changes * changes * changes * change * search changes * changes * new fixes * new changes * test cases fix * test fix * api changes * checkes reverted * new changes for fe * changes * test coverage * user updates changes * scv changes and test coverage * unused code removed * menu item * route fix * test fixes * naming fixes * unused imports * review changes * trapd documentation * response messages update * validator fix * DAO update fix * config dao fix * DAO fixes * changelog * changes * menu code revert * review comment
christianpape
changed the title
cgorantla
previously requested changes
Apr 14, 2026
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
Haven't validated this manually. Will do it before I approve.
fix SHA2** are getting rejected remove general config and note Allow snmp-trap-address to be optional
This will allow users to disable trapd
This will prevent leaking of user authentication details
cgorantla
force-pushed
the
features/trapd-config-db-migration
branch
from
75027c8 to
96ae154
Compare
cgorantla
changed the title
cgorantla
approved these changes
Apr 22, 2026
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
LGTM!
Filed few more issues on https://opennms.atlassian.net/browse/NMS-19128 that needs to be solved but they shouldn't block this merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.